From owner-freebsd-bugs@FreeBSD.ORG Tue Dec 12 15:03:06 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0499F16A53D for ; Tue, 12 Dec 2006 15:03:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id 278C243D31 for ; Tue, 12 Dec 2006 14:59:20 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kBCF0IBB084025 for ; Tue, 12 Dec 2006 15:00:19 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kBCF0IbT084024; Tue, 12 Dec 2006 15:00:18 GMT (envelope-from gnats) Resent-Date: Tue, 12 Dec 2006 15:00:18 GMT Resent-Message-Id: <200612121500.kBCF0IbT084024@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Eygene Ryabinkin Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8CB8C16A4AB for ; Tue, 12 Dec 2006 14:53:50 +0000 (UTC) (envelope-from rea-fbsd@codelabs.ru) Received: from pobox.codelabs.ru (pobox.codelabs.ru [144.206.177.45]) by mx1.FreeBSD.org (Postfix) with ESMTP id 89DBE43CDA for ; Tue, 12 Dec 2006 14:49:03 +0000 (GMT) (envelope-from rea-fbsd@codelabs.ru) Received: from localdomain by pobox.codelabs.ru with local id 1Gu8xJ-000IgB-58 for FreeBSD-gnats-submit@freebsd.org; Tue, 12 Dec 2006 17:50:05 +0300 Message-Id: Date: Tue, 12 Dec 2006 17:50:05 +0300 From: Eygene Ryabinkin Sender: rea-fbsd@codelabs.ru To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/106645: uart device description in 7-CURRENT is sometimes overwritten X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Eygene Ryabinkin List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2006 15:03:06 -0000 >Number: 106645 >Category: kern >Synopsis: uart device description in 7-CURRENT is sometimes overwritten >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Dec 12 15:00:17 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Eygene Ryabinkin >Release: FreeBSD 7.0-CURRENT i386 >Organization: Code Labs >Environment: System: FreeBSD XXX 7.0-CURRENT FreeBSD 7.0-CURRENT #2: Sun Dec 10 21:49:11 MSK 2006 root@XXX:/usr/src/sys/i386/compile/XXX-7 i386 >Description: The uart driver sets PCMCIA card description (for example, in uart_bus_pci.c), but it is the overwritten by the base ns8250 code in uart_dev_ns8250.c. >How-To-Repeat: Take some PCMCIA card that is supported by the uart driver and insert it. Then watch for the kernel messages. >Fix: Simple patch: check if description is already here. --- uart_dev_ns8250.c.orig Sun Dec 10 21:47:23 2006 +++ uart_dev_ns8250.c Sun Dec 10 21:48:47 2006 @@ -634,7 +634,9 @@ uart_setreg(bas, REG_MCR, mcr); uart_barrier(bas); sc->sc_rxfifosz = sc->sc_txfifosz = 1; - device_set_desc(sc->sc_dev, "8250 or 16450 or compatible"); + if (device_get_desc(sc->sc_dev) == NULL) + device_set_desc(sc->sc_dev, + "8250 or 16450 or compatible"); return (0); } @@ -694,20 +696,25 @@ describe: if (count >= 14 && count <= 16) { sc->sc_rxfifosz = 16; - device_set_desc(sc->sc_dev, "16550 or compatible"); + if (device_get_desc(sc->sc_dev) == NULL) + device_set_desc(sc->sc_dev, "16550 or compatible"); } else if (count >= 28 && count <= 32) { sc->sc_rxfifosz = 32; - device_set_desc(sc->sc_dev, "16650 or compatible"); + if (device_get_desc(sc->sc_dev) == NULL) + device_set_desc(sc->sc_dev, "16650 or compatible"); } else if (count >= 56 && count <= 64) { sc->sc_rxfifosz = 64; - device_set_desc(sc->sc_dev, "16750 or compatible"); + if (device_get_desc(sc->sc_dev) == NULL) + device_set_desc(sc->sc_dev, "16750 or compatible"); } else if (count >= 112 && count <= 128) { sc->sc_rxfifosz = 128; - device_set_desc(sc->sc_dev, "16950 or compatible"); + if (device_get_desc(sc->sc_dev) == NULL) + device_set_desc(sc->sc_dev, "16950 or compatible"); } else { sc->sc_rxfifosz = 16; - device_set_desc(sc->sc_dev, - "Non-standard ns8250 class UART with FIFOs"); + if (device_get_desc(sc->sc_dev) == NULL) + device_set_desc(sc->sc_dev, + "Non-standard ns8250 class UART with FIFOs"); } /* >Release-Note: >Audit-Trail: >Unformatted: