From owner-freebsd-current@FreeBSD.ORG  Wed Aug 13 12:51:52 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2E16E37B401; Wed, 13 Aug 2003 12:51:52 -0700 (PDT)
Received: from ns1.xcllnt.net (209-128-86-226.BAYAREA.NET [209.128.86.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 59D1B43F75; Wed, 13 Aug 2003 12:51:51 -0700 (PDT)
	(envelope-from marcel@xcllnt.net)
Received: from dhcp42.pn.xcllnt.net (dhcp42.pn.xcllnt.net [192.168.4.242])
	by ns1.xcllnt.net (8.12.9/8.12.9) with ESMTP id h7DJppwO088959;
	Wed, 13 Aug 2003 12:51:51 -0700 (PDT)
	(envelope-from marcel@piii.pn.xcllnt.net)
Received: from dhcp42.pn.xcllnt.net (localhost [127.0.0.1])
	by dhcp42.pn.xcllnt.net (8.12.9/8.12.9) with ESMTP id h7DJpf2F000949;
	Wed, 13 Aug 2003 12:51:41 -0700 (PDT)
	(envelope-from marcel@dhcp42.pn.xcllnt.net)
Received: (from marcel@localhost)
	by dhcp42.pn.xcllnt.net (8.12.9/8.12.9/Submit) id h7DJpf8S000948;
	Wed, 13 Aug 2003 12:51:41 -0700 (PDT)
	(envelope-from marcel)
Date: Wed, 13 Aug 2003 12:51:41 -0700
From: Marcel Moolenaar <marcel@xcllnt.net>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20030813195141.GA919@dhcp42.pn.xcllnt.net>
References: <20030813180202.GA643@dhcp42.pn.xcllnt.net>
	<XFMail.20030813143415.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <XFMail.20030813143415.jhb@FreeBSD.org>
User-Agent: Mutt/1.5.4i
cc: current@FreeBSD.org
Subject: Re: LOR: sigacts vs Giant
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Aug 2003 19:51:52 -0000

On Wed, Aug 13, 2003 at 02:34:15PM -0400, John Baldwin wrote:
> 
> 
> sendsig() on ia64 drops the lock around the copyout, see line 921 in
> machdep.c.  It is not reacquired again until the very end of the
> function.  You could change the assert at the top of the function to
> say that sigacts is not recursed, but sigacts is already a non
> recursive lock.  Do you have local diffs to HEAD?

Argh, yes. I thought the behaviour was identical to the copyout()
case, otherwise I wouldn't have reported it. I missed the unlock
on line 921. My bad, sorry,

-- 
 Marcel Moolenaar	  USPA: A-39004		 marcel@xcllnt.net