From owner-freebsd-isdn Sat Aug 1 00:32:11 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA13845 for freebsd-isdn-outgoing; Sat, 1 Aug 1998 00:32:11 -0700 (PDT) (envelope-from owner-freebsd-isdn@FreeBSD.ORG) Received: from mail.ppp.net (mail.ppp.net [194.64.12.35]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA13840 for ; Sat, 1 Aug 1998 00:32:08 -0700 (PDT) (envelope-from ernie!bert.kts.org!hm@ppp.net) Received: from casparc.ppp.net (casparc2.ppp.net [194.64.12.42]) by mail.ppp.net (8.8.8/8.8.8) with SMTP id JAA27692; Sat, 1 Aug 1998 09:32:02 +0200 Received: from ernie by casparc.ppp.net with uucp (Smail3.1.28.1 #1) id m0z2W93-002ZjZC; Sat, 1 Aug 98 09:32 MET DST Received: from bert.kts.org(really [194.55.156.2]) by ernie.kts.org via sendmail with smtp id for ; Sat, 1 Aug 1998 09:02:59 +0200 (CEST) (Smail-3.2.0.91 1997-Jan-14 #3 built 1998-Feb-14) Received: by bert.kts.org via sendmail with stdio id for freebsd-isdn@FreeBSD.ORG; Sat, 1 Aug 1998 08:56:57 +0200 (CEST) (Smail-3.2.0.94 1997-Apr-22 #1 built 1998-Jun-6) Message-Id: From: hm@kts.org (Hellmuth Michaelis) Subject: Re: Preparations for BSD/OS port In-Reply-To: <35C1BA3B.19A3A3B8@nl.compuware.com> from Bert Driehuis at "Jul 31, 98 02:36:11 pm" To: bert_driehuis@nl.compuware.com (Bert Driehuis) Date: Sat, 1 Aug 1998 08:56:57 +0200 (CEST) Cc: freebsd-isdn@FreeBSD.ORG Organization: Kitchen Table Systems Reply-To: hm@kts.org X-Mailer: ELM [version 2.4ME+ PL38 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org Bert Driehuis wrote: > I'm working on porting ISDN4BSD to BSD/OS 3.0. The telephony part works, Great! > FreeBSD and BSD/OS it's a u_long. How 'bout doing this in i4b_ioctl.h: > > #if defined(__FreeBSD__) || defined(__bsdi__) > #define I4B_IOCTL_CMD_T u_long > #else > #define I4B_IOCTL_CMD_T int > #endif Looks ok. > Another, along the lines of the FLAGS definition in layer1/i4b_isic.c, is to > use a #define PARMS to pass the right info down to the probe and attach Hmm, i dont like this. IMHO the differences in data types (as above) should be hidden, but function arguments not - its confusing. > The biggest gain might come from removing "all" platform dependancies from the > card drivers, and moving the OS dependent probe/attach stuff into i4b_isic.c > (or at least into isolated sections in the card specific file). For example, > the tel_s0163_probe in i4b_tel_s0163.c is defined now in two and soon three > radically different ifdeffed routines, with the guts of the probe duplicated > two or three times. This would require some serious thinking. Anyway, I'm not > going to even *think* about tackling that issue :-) Perhaps this can go in three files, i4b_probeattach_fbsd.c, i4b_probeattach_nbsd.c and i4b_probeattach_bsdos.c ? > What do you think? #ifdef or #define? And if we want to use definitions like > I4B_IOCTL_CMD_T throughout ISDN4BSD, which include file do we stick it in? i4b_global.h hellmuth -- Hellmuth Michaelis hm@kts.org Hamburg, Europe A duck is like a bicycle because they both have two wheels except the duck (terry@cs.weber.edu) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message