From owner-freebsd-virtualization@FreeBSD.ORG  Mon Jul 22 21:38:12 2013
Return-Path: <owner-freebsd-virtualization@FreeBSD.ORG>
Delivered-To: freebsd-virtualization@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id 66F93FF3;
 Mon, 22 Jul 2013 21:38:12 +0000 (UTC) (envelope-from zec@fer.hr)
Received: from mail.fer.hr (mail.fer.hr [161.53.72.233])
 (using TLSv1 with cipher AES128-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id F09852661;
 Mon, 22 Jul 2013 21:38:11 +0000 (UTC)
Received: from x23.lan (141.136.246.215) by MAIL.fer.hr (161.53.72.233) with
 Microsoft SMTP Server (TLS) id 14.2.342.3; Mon, 22 Jul 2013 23:38:09 +0200
From: Marko Zec <zec@fer.hr>
To: <freebsd-virtualization@freebsd.org>
Subject: Re: VIMAGE + PF crash in mbuf destructor
Date: Mon, 22 Jul 2013 23:38:09 +0200
User-Agent: KMail/1.9.10
References: <CAG=rPVfxFiOVOeSyDP=wBubNQCHK5dqcgBBaJjeS6XXtSZSZqg@mail.gmail.com>
 <CAG=rPVd3F2sfwizJuEngxexo0Rby2qwzqpAB4_K-fZXXb8-Rmw@mail.gmail.com>
 <CAJ-Vmo=jDPrJHXRz8xY9aA-soBx54DjvqkpzdSUvr+4hZ9ExkQ@mail.gmail.com>
In-Reply-To: <CAJ-Vmo=jDPrJHXRz8xY9aA-soBx54DjvqkpzdSUvr+4hZ9ExkQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-ID: <201307222338.09833.zec@fer.hr>
X-Originating-IP: [141.136.246.215]
Cc: Adrian Chadd <adrian@freebsd.org>, freebsd-pf@freebsd.org
X-BeenThere: freebsd-virtualization@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussion of various virtualization techniques FreeBSD supports."
 <freebsd-virtualization.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-virtualization>
List-Post: <mailto:freebsd-virtualization@freebsd.org>
List-Help: <mailto:freebsd-virtualization-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization>, 
 <mailto:freebsd-virtualization-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Jul 2013 21:38:12 -0000

On Monday 22 July 2013 21:01:31 Adrian Chadd wrote:
> Well I'm worried about _other_ stuff causing issues here.
>
> So - what's the "right" behaviour? Does vnet/vimage make the
> assumption that for all the mbuf processing/free operations, the vnet
> tag/state is set?

To the best of my knowledge, there's nothing vnet-specific in any of the 
mbuf-handling routines, i.e. they should all work fine on a VIMAGE kernel 
even if curvnet isn't set.

My original motivation behind keeping separate UMA zones for each vnet was 
solely to capture resource leaks between vnets in the early days of VIMAGE 
prototyping.  Nothing prevents a single UMA zone to be shared by multiple 
vnets, unless we want to enforce per-vnet limitations on the number of 
items in a zone.

Marko


>
> -adrian
>
> On 22 July 2013 11:59, Craig Rodrigues <rodrigc@freebsd.org> wrote:
> > On Mon, Jul 22, 2013 at 10:11 AM, Adrian Chadd <adrian@freebsd.org> 
wrote:
> >> I don't think the default vnet context is the correct behaviour there.
> >> We'd need to figure out what the vnet context of the mbuf is and set
> >> that.
> >
> > What do you think about Marko's suggestion to de-virtualize
> > V_pf_mtag_z?  What would be the down side of that?
> >
> > I don't understand enough of the PF code to understand which variables
> > need to
> > be virtual and which don't.
> >
> > --
> > Craig
>
> _______________________________________________
> freebsd-virtualization@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-virtualization
> To unsubscribe, send any mail to
> "freebsd-virtualization-unsubscribe@freebsd.org"