From owner-freebsd-current@FreeBSD.ORG Fri Jun 6 16:16:46 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 61B1D1065670 for ; Fri, 6 Jun 2008 16:16:46 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.76]) by mx1.freebsd.org (Postfix) with ESMTP id 650098FC39 for ; Fri, 6 Jun 2008 16:16:46 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtp015.mac.com (asmtp015-bge351000 [10.150.69.78]) by smtpoutm.mac.com (Xserve/smtpout013/MantshX 4.0) with ESMTP id m56G29oO009047 for ; Fri, 6 Jun 2008 09:02:09 -0700 (PDT) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Received: from macbook-pro.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp015.mac.com (Sun Java(tm) System Messaging Server 6.3-6.03 (built Mar 14 2008; 32bit)) with ESMTPSA id <0K21001OMTVJ6SB1@asmtp015.mac.com> for freebsd-current@freebsd.org; Fri, 06 Jun 2008 09:02:08 -0700 (PDT) Message-id: <018816ED-8FF3-4834-AD17-59637C87D30D@mac.com> From: Marcel Moolenaar To: Mike Tancsa In-reply-to: <200806061259.m56CxhdR045603@lava.sentex.ca> Date: Fri, 06 Jun 2008 09:02:05 -0700 References: <200806061259.m56CxhdR045603@lava.sentex.ca> X-Mailer: Apple Mail (2.924) Cc: freebsd-current@freebsd.org Subject: Re: PUC rewrite X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jun 2008 16:16:46 -0000 On Jun 6, 2008, at 5:59 AM, Mike Tancsa wrote: > I have been starting to take a look at moving some of our embedded > platforms to RELENG_7 and noticed that support for the 3Com PCI > cards are broken. Previously, in pucdata.c, they were defined as > > /* US Robotics (3Com) PCI Modems */ > { "US Robotics (3Com) 3CP5609 PCI 16550 Modem", > { 0x12b9, 0x1008, 0, 0 }, > { 0xffff, 0xffff, 0, 0 }, > { > { PUC_PORT_TYPE_COM, 0x10, 0x00, COM_FREQ }, > }, > }, > > > However, in the newer version they are not there, and uart is not > picking up the device. Since this is a single-port UART, puc(4) is not supposed to have support for it. The uart(4) can handle it without needing puc(4). However, that implies that uart(4) needs to have the support for it and I guess that's not present. > In the new re-write, what is the proper way to add support for > devices no longer recognized ? Add the PCI Ids to uart_bus_pci.c. Keep the list of Ids sorted, because it's assumed by uart_pci_match(). If you can send me a patch, I'll commit to head and stable. FYI, -- Marcel Moolenaar xcllnt@mac.com