From owner-freebsd-current@FreeBSD.ORG Fri Dec 23 09:42:16 2005 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E9D4A16A41F; Fri, 23 Dec 2005 09:42:16 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8795543D64; Fri, 23 Dec 2005 09:42:16 +0000 (GMT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (unknown [192.168.48.2]) by phk.freebsd.dk (Postfix) with ESMTP id 85F23BC66; Fri, 23 Dec 2005 09:42:14 +0000 (UTC) To: Jason Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Fri, 23 Dec 2005 01:14:08 PST." Date: Fri, 23 Dec 2005 10:42:13 +0100 Message-ID: <26783.1135330933@critter.freebsd.dk> Sender: phk@critter.freebsd.dk Cc: freebsd-current@freebsd.org Subject: Re: New malloc ready, take 42 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Dec 2005 09:42:17 -0000 In message , Jason Evans writes: >So, how about it? Is jemalloc ready to go in now? Sounds like it to me :-) Various fatherly advice: During the first part of the integration period performance is not important, correctness is. Enable all reasonable checks. If you have something like phkmallocs EXTRA_SANITY, turn it on. There will be whineage about performance and how FreeBSD is dying etc, just ignore it, those people havn't got a clue and you'll get to show them later when the checks are turned off. I also advice that you to keep both mallocs in the tree for a transition period and define an environment variable that causes fallback to phkmalloc. That way you don't risk stopping people dead in their tracks if some unforseen sideeffect shows up. Regarding unforseen sideeffects, the thing I would worry most about is alignment, where phkmalloc is very generous. And once again: Thankyou! Poul-Henning -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.