From owner-cvs-src Wed Feb 19 15:35:23 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 50D7F37B401; Wed, 19 Feb 2003 15:35:21 -0800 (PST) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5F62043FAF; Wed, 19 Feb 2003 15:35:20 -0800 (PST) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (IDENT:brdavis@localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.12.3/8.12.3) with ESMTP id h1JNZDJu014442; Wed, 19 Feb 2003 15:35:13 -0800 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.12.3/8.12.3/Submit) id h1JNZDQY014441; Wed, 19 Feb 2003 15:35:13 -0800 Date: Wed, 19 Feb 2003 15:35:13 -0800 From: Brooks Davis To: Sam Leffler Cc: Maxime Henrion , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/pci if_xl.c Message-ID: <20030219153513.A3364@Odin.AC.HMC.Edu> References: <200302191833.h1JIXT2d013173@repoman.freebsd.org> <0b4101c2d864$49cbafd0$52557f42@errno.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="+QahgC5+KEYLbs62" Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <0b4101c2d864$49cbafd0$52557f42@errno.com>; from sam@errno.com on Wed, Feb 19, 2003 at 02:14:35PM -0800 X-Virus-Scanned: by amavisd-milter (http://amavis.org/) on odin.ac.hmc.edu Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG --+QahgC5+KEYLbs62 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 19, 2003 at 02:14:35PM -0800, Sam Leffler wrote: > > We should probably move all the other DMA map creations in > > xl_attach() where we can really handle them failing, since > > xl_init() is void and shouldn't fail. >=20 > When I did the struct ifnet fixups I almost changed if_init from void to = int > to return an error code. Maybe it's not too late to do this before the > REELNG_5 branch? Personaly, I'd like to make the switch to if_xname as well so breaking the struct ifnet API is fine with me. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --+QahgC5+KEYLbs62 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE+VBSwXY6L6fI4GtQRAtM+AKDYRlnZjaW18QV3svIkQHbzxBE6bQCghMeU /09orytPgdy8LeyOc3afBgY= =f3x2 -----END PGP SIGNATURE----- --+QahgC5+KEYLbs62-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message