From owner-cvs-src@FreeBSD.ORG Fri Apr 29 21:53:14 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4B9F916A4CE; Fri, 29 Apr 2005 21:53:14 +0000 (GMT) Received: from hadar.amcc.com (hadar.amcc.com [192.195.69.168]) by mx1.FreeBSD.org (Postfix) with ESMTP id EB67343D48; Fri, 29 Apr 2005 21:53:13 +0000 (GMT) (envelope-from vkashyap@amcc.com) Received: from mailhost01.amcc.com ([192.195.69.30]) by hadar.amcc.com (Netscape Messaging Server 4.15) with SMTP id IFQA4P03.R6P; Fri, 29 Apr 2005 14:53:13 -0700 Received: (from vkashyap-pc [10.66.13.13]) by mailhost01.amcc.com (SMSSMTP 4.0.0.59) with SMTP id M2005042914540416957 ; Fri, 29 Apr 2005 14:54:05 -0700 From: "Vinod Kashyap" To: Scott Long Date: Fri, 29 Apr 2005 14:53:08 -0700 X-Sent-Folder-Path: Sent Items X-Mailer: Oracle Connector for Outlook 9.0.4 51114 (9.0.6627) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Message-ID: cc: "Bjoern A. Zeeb" cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: RE: cvs commit: src/sys/dev/twa tw_osl_cam.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Apr 2005 21:53:14 -0000 > -----Original Message----- > From: owner-src-committers@FreeBSD.org > [mailto:owner-src-committers@FreeBSD.org]On Behalf Of Scott Long > Sent: Friday, April 29, 2005 2:24 PM > To: Vinod Kashyap > Cc: Bjoern A. Zeeb; src-committers@FreeBSD.org; cvs-src@FreeBSD.org; > cvs-all@FreeBSD.org > Subject: Re: cvs commit: src/sys/dev/twa tw_osl_cam.c > = > = > Vinod Kashyap wrote: > > = > >>-----Original Message----- > >>From: owner-src-committers@FreeBSD.org > >>[mailto:owner-src-committers@FreeBSD.org]On Behalf Of Bjoern A. Zeeb > >>Sent: Friday, April 29, 2005 1:29 PM > >>To: Vinod Kashyap > >>Cc: src-committers@FreeBSD.org; cvs-src@FreeBSD.org; = > >>cvs-all@FreeBSD.org > >>Subject: Re: cvs commit: src/sys/dev/twa tw_osl_cam.c > >> > >> > >>On Fri, 29 Apr 2005, Vinod Kashyap wrote: > >> > >> > >>>vkashyap 2005-04-29 20:03:20 UTC > >>> > >>> FreeBSD src repository > >>> > >>> Modified files: > >>> sys/dev/twa tw_osl_cam.c > >>> Log: > >>> Make call to tw_cl_deferred_interrupt in twa_poll, not = > >> > >>dependent on the > >> > >>> return value from tw_cl_interrupt. > >>> > >>> Revision Changes Path > >>> 1.2 +12 -2 src/sys/dev/twa/tw_osl_cam.c > >> > >>With this I can reboot the machine again. Thanks. > >> > > = > > = > > I still believe that CAM should not be calling the polling function > > when interrupts are active, but in the absence of an answer to why > > that is so, this can be a work-around. > > = > > = > = > CAM calls the poll routine when it's not sure if interrupts are > enabled and it wants to make sure that SIM will complete all > outstanding commands. It's the same way that every other CAM In that case, it's probably a good idea to define SIM entry points that CAM can call to enable/disable interrupts on the controller. By doing this, CAM can first disable interrupts, and then go ahead and poll. > driver in the tree is written. > = > Scott >