From owner-svn-ports-head@FreeBSD.ORG Fri Jun 27 03:24:07 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 7036D2BE for ; Fri, 27 Jun 2014 03:24:07 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3E2CE2804 for ; Fri, 27 Jun 2014 03:24:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.8/8.14.8) with ESMTP id s5R3O7sm010497 for ; Fri, 27 Jun 2014 03:24:07 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id s5R3O7tN010488 for svn-ports-head@freebsd.org; Fri, 27 Jun 2014 03:24:07 GMT (envelope-from bdrewery) Received: (qmail 67200 invoked from network); 26 Jun 2014 22:24:05 -0500 Received: from unknown (HELO blah) (freebsd@shatow.net@10.10.1.90) by sweb.xzibition.com with ESMTPA; 26 Jun 2014 22:24:05 -0500 Message-ID: <53ACE3D4.2060507@FreeBSD.org> Date: Thu, 26 Jun 2014 22:24:04 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Nathan Whitehorn , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r359424 - head/Mk/Uses References: <201406262216.s5QMGcd8049387@svn.freebsd.org> <53ACE26E.1080204@FreeBSD.org> In-Reply-To: <53ACE26E.1080204@FreeBSD.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: baptiste Daroussin X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jun 2014 03:24:07 -0000 On 6/26/14, 10:18 PM, Bryan Drewery wrote: > > On 6/26/14, 5:16 PM, Nathan Whitehorn wrote: >> Author: nwhitehorn (src committer) >> Date: Thu Jun 26 22:16:37 2014 >> New Revision: 359424 >> URL: http://svnweb.freebsd.org/changeset/ports/359424 >> QAT: https://qat.redports.org/buildarchive/r359424/ >> >> Log: >> On some Tier-2 platforms (e.g. PowerPC), clang kind of works and so is >> installed but is not cc. On such platforms, clang is usually not >> default >> for a reason and so using it for C++11 is unwise. Instead, fall >> back to >> newer GCC. On i386 and amd64, clang works even if it isn't the >> default, >> so continue using it there. >> >> This fixes the build for Boost, among other software, on PowerPC. >> >> Approved by: bapt >> >> Modified: >> head/Mk/Uses/compiler.mk >> >> Modified: head/Mk/Uses/compiler.mk >> ============================================================================== >> >> --- head/Mk/Uses/compiler.mk Thu Jun 26 22:08:49 2014 (r359423) >> +++ head/Mk/Uses/compiler.mk Thu Jun 26 22:16:37 2014 (r359424) >> @@ -75,7 +75,9 @@ ALT_COMPILER_VERSION= 0 >> ALT_COMPILER_TYPE= none >> _ALTCCVERSION= >> .if ${COMPILER_TYPE} == gcc && exists(/usr/bin/clang) >> +.if ${ARCH} == amd64 || ${ARCH} == i386 # clang often non-default for >> a reason >> _ALTCCVERSION!= /usr/bin/clang --version >> +.endif >> .elif ${COMPILER_TYPE} == clang && exists(/usr/bin/gcc) >> _ALTCCVERSION!= /usr/bin/gcc --version >> .endif >> @@ -138,7 +140,7 @@ CHOSEN_COMPILER_TYPE= gcc >> >> .if ${_COMPILER_ARGS:Mc++11-lang} >> .if !${COMPILER_FEATURES:Mc++11} >> -.if defined(FAVORITE_COMPILER) && ${FAVORITE_COMPILER} == gcc >> +.if (defined(FAVORITE_COMPILER) && ${FAVORITE_COMPILER} == gcc) || >> (${ARCH} != amd64 || ${ARCH} != i386) # clang not always supported on >> Tier-2 > > This is wrong. > > This is now requiring gcc on amd64? > > [00:00:51] ====>> Deleting boost-libs-1.55.0_3.txz: new dependency: > lang/gcc > [00:00:52] ====>> Deleting boost-python-libs-1.55.0.txz: new dependency: > lang/gcc > > > This is requiring gcc if arch != i386 or arch != amd64 ... which is always. > >> USE_GCC= yes >> CHOSEN_COMPILER_TYPE= gcc >> .elif (${COMPILER_TYPE} == clang && ${COMPILER_VERSION} < 33) || >> ${COMPILER_TYPE} == gcc >> > > Fixed in r359440. -- Regards, Bryan Drewery