From owner-freebsd-fs@FreeBSD.ORG Wed Jun 29 09:03:02 2011 Return-Path: Delivered-To: fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 96A921065674; Wed, 29 Jun 2011 09:03:02 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from mail.ebusiness-leidinger.de (mail.ebusiness-leidinger.de [217.11.53.44]) by mx1.freebsd.org (Postfix) with ESMTP id 2B3A38FC08; Wed, 29 Jun 2011 09:03:01 +0000 (UTC) Received: from outgoing.leidinger.net (p4FC4623A.dip.t-dialin.net [79.196.98.58]) by mail.ebusiness-leidinger.de (Postfix) with ESMTPSA id DD3B184400D; Wed, 29 Jun 2011 10:46:35 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [IPv6:fd73:10c7:2053:1::3:102]) by outgoing.leidinger.net (Postfix) with ESMTP id 32EB12012; Wed, 29 Jun 2011 10:46:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=Leidinger.net; s=outgoing-alex; t=1309337193; bh=TdTgZGsh1g8dYBTrtKV8yMyseE9wUAfYHEfJgW0g4jw=; h=Message-ID:Date:From:To:Cc:Subject:References:In-Reply-To: MIME-Version:Content-Type:Content-Transfer-Encoding; b=OA4QJmOi49QXvPN7nnXxdhj12226VFhJy0x6lJyHEoMtADAQIdekqecWnPjcJmd5N ZSO19qf5TqaloVsDe/sx20/TxKgS8Be/PTE6duuFdppej13Tr1SmmxKsBMnl/Grcku /HqpjCyJI/zjGenI10cp68e9nn9cM8kp9hQjseNPw7eLfbSfxEmwE8zjxI0lrrfkQN 3qxgiL8K+3NpDmabkU3JXCcrYivV/huRRWbK/oBOiCyrSZRxwFN1lmlNiKnv/TNVMP N4DAzKjBWDzuwzhgL34yaX4gfpMhnwffCPKiIjuNSTmuIsbll8sZIDrVFH9wIDHBwU pdBGBqPLKBsnQ== Received: (from www@localhost) by webmail.leidinger.net (8.14.4/8.14.4/Submit) id p5T8kXkY017871; Wed, 29 Jun 2011 10:46:33 +0200 (CEST) (envelope-from Alexander@Leidinger.net) X-Authentication-Warning: webmail.leidinger.net: www set sender to Alexander@Leidinger.net using -f Received: from pslux.ec.europa.eu (pslux.ec.europa.eu [158.169.9.14]) by webmail.leidinger.net (Horde Framework) with HTTP; Wed, 29 Jun 2011 10:46:33 +0200 Message-ID: <20110629104633.26824evikzh8tgtl@webmail.leidinger.net> Date: Wed, 29 Jun 2011 10:46:33 +0200 From: Alexander Leidinger To: Glen Barber References: <20110628203228.GA4957@onyx.glenbarber.us> In-Reply-To: <20110628203228.GA4957@onyx.glenbarber.us> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: 7bit User-Agent: Dynamic Internet Messaging Program (DIMP) H3 (1.1.6) X-EBL-MailScanner-Information: Please contact the ISP for more information X-EBL-MailScanner-ID: DD3B184400D.A22FE X-EBL-MailScanner: Found to be clean X-EBL-MailScanner-SpamCheck: not spam, spamhaus-ZEN, SpamAssassin (not cached, score=-0.023, required 6, autolearn=disabled, DKIM_SIGNED 0.10, DKIM_VALID -0.10, DKIM_VALID_AU -0.10, TW_ZF 0.08) X-EBL-MailScanner-From: alexander@leidinger.net X-EBL-MailScanner-Watermark: 1309941996.43609@nI0f0mRNFD5V9X5MRkG4Zg X-EBL-Spam-Status: No Cc: fs@FreeBSD.org Subject: Re: [RFC] [patch] periodic status-zfs: list pools in daily emails X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2011 09:03:02 -0000 Quoting Glen Barber (from Tue, 28 Jun 2011 16:32:28 -0400): > Hi, > > I'd like to get some feedback on a change I made to 404.status-zfs. > > I added a default behavior to list the pools on the system, in addition to > checking if the pool is healthy. I think it might be useful for others to > have this as the default behavior, for example on systems where dedup is > enabled to track the dedup statistics over time. I do not think this is a bad idea to be able to see the pools... but IMHO it should be configurable (no strong opinion about "enabled or disabled by default"). > The output of the the script after my changes follows: Info to others: this is the default output, there is no special option to track DEDUP. > Checking status of zfs pools: > NAME SIZE ALLOC FREE CAP DEDUP HEALTH ALTROOT > zroot 456G 147G 309G 32% 1.00x ONLINE - > zstore 928G 258G 670G 27% 1.00x ONLINE - > all pools are healthy > > Feedback would be appreciated. A diff is attached. Did you test it with an unhealthy pool? If yes, how does the result look like? For the healthy case we have redundant info (but as the brain is good at pattern matching, I would object to replace the status with the list output, in case someone would suggest this). In the unhealthy case we will surely have more info, my inquiry about it is if an empty line between the list and the status would make it more readable or not. Bye, Alexander. -- NOTICE: -- THE ELEVATORS WILL BE OUT OF ORDER TODAY -- (The nearest working elevator is in the building across the street.) http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137