From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Apr 21 08:30:12 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D8F0D1065672 for ; Thu, 21 Apr 2011 08:30:12 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9AD9A8FC12 for ; Thu, 21 Apr 2011 08:30:12 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p3L8UCia069316 for ; Thu, 21 Apr 2011 08:30:12 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p3L8UCcW069311; Thu, 21 Apr 2011 08:30:12 GMT (envelope-from gnats) Resent-Date: Thu, 21 Apr 2011 08:30:12 GMT Resent-Message-Id: <201104210830.p3L8UCcW069311@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Pan Tsu Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CB9161065677 for ; Thu, 21 Apr 2011 08:29:00 +0000 (UTC) (envelope-from inyaoo@gmail.com) Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com [74.125.82.182]) by mx1.freebsd.org (Postfix) with ESMTP id 609538FC15 for ; Thu, 21 Apr 2011 08:28:59 +0000 (UTC) Received: by wyf23 with SMTP id 23so1541596wyf.13 for ; Thu, 21 Apr 2011 01:28:59 -0700 (PDT) Received: by 10.227.150.17 with SMTP id w17mr8492507wbv.95.1303374538852; Thu, 21 Apr 2011 01:28:58 -0700 (PDT) Received: from localhost ([87.236.194.191]) by mx.google.com with ESMTPS id o6sm1035268wbo.20.2011.04.21.01.28.55 (version=SSLv3 cipher=OTHER); Thu, 21 Apr 2011 01:28:58 -0700 (PDT) Message-Id: <86bp00ovnr.fsf@gmail.com> Date: Thu, 21 Apr 2011 12:28:40 +0400 From: Pan Tsu To: FreeBSD-gnats-submit@FreeBSD.org Cc: Subject: ports/156543: [patch] Mk/bsd.cmake.mk: distinguish STRIP from WITH_DEBUG X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2011 08:30:12 -0000 >Number: 156543 >Category: ports >Synopsis: [patch] Mk/bsd.cmake.mk: distinguish STRIP from WITH_DEBUG >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Apr 21 08:30:12 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Pan Tsu >Release: FreeBSD 9.0-CURRENT amd64 >Organization: >Environment: >Description: Respect STRIP for USE_CMAKE ports like INSTALL_MACROS do. - some VMs embed data in way that stripping makes produced executable broken - some bugs can only be reproduced with optimization enabled - compile-time debugging may be useful without symbols, e.g. asserts >How-To-Repeat: >Fix: --- a.diff begins here --- Index: Mk/bsd.cmake.mk =================================================================== RCS file: /a/.cvsup/ports/Mk/bsd.cmake.mk,v retrieving revision 1.9 diff -u -p -r1.9 bsd.cmake.mk --- Mk/bsd.cmake.mk 10 Apr 2011 08:40:13 -0000 1.9 +++ Mk/bsd.cmake.mk 21 Apr 2011 07:31:44 -0000 @@ -73,6 +73,9 @@ CMAKE_INSTALL_PREFIX?= ${PREFIX} CMAKE_BUILD_TYPE?= Debug .else CMAKE_BUILD_TYPE?= Release +.endif + +.if defined(STRIP) && ${STRIP} != "" INSTALL_TARGET?= install/strip .endif --- a.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted: