From owner-freebsd-current@FreeBSD.ORG Tue May 13 12:00:48 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1A3D937B405; Tue, 13 May 2003 12:00:48 -0700 (PDT) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id DEFA443F93; Tue, 13 May 2003 12:00:46 -0700 (PDT) (envelope-from scott_long@btc.adaptec.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h4DIuxZ15434; Tue, 13 May 2003 11:56:59 -0700 Received: from btc.adaptec.com ([10.100.0.149]) by redfish.adaptec.com (8.8.8p2+Sun/8.8.8) with ESMTP id MAA08973; Tue, 13 May 2003 12:00:41 -0700 (PDT) Message-ID: <3EC14031.7050101@btc.adaptec.com> Date: Tue, 13 May 2003 12:57:53 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3) Gecko/20030414 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: In-Reply-To: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-current@FreeBSD.org cc: Doug Barton cc: re@FreeBSD.org Subject: Re: sysinstall non-USB mouse dialog confusing X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 May 2003 19:00:48 -0000 John Baldwin wrote: > On 12-May-2003 Scott Long wrote: > >>John Baldwin wrote: >> >>>On 12-May-2003 John Baldwin wrote: >>> >>> >>>>>Enable support for a PS/2 (non-USB) mouse? Yes [No] >>>> >>>>Perhaps the dialog should be reworded to say 'PS/2, Serial, or Bus mouse'. >>> >>> >>>Index: install.c >>>=================================================================== >>>RCS file: /usr/cvs/src/usr.sbin/sysinstall/install.c,v >>>retrieving revision 1.341 >>>diff -u -r1.341 install.c >>>--- install.c 20 Apr 2003 14:08:04 -0000 1.341 >>>+++ install.c 12 May 2003 18:33:54 -0000 >>>@@ -662,7 +662,7 @@ >>> >>> #ifdef WITH_MICE >>> dialog_clear_norefresh(); >>>- if (!msgNoYes("Does this system have a non-USB mouse attached to it?")) >>>+ if (!msgNoYes("Does this system have a PS/2, serial, or bus mouse?")) >>> dmenuOpenSimple(&MenuMouse, FALSE); >>> #endif >>> >>>Does this make everyone happy with the mouse question? >>> >> >>Yes. My gut feeling is to also > > > So is the above diff approved? > Approved! =-) > >>1) default the above dialog to TRUE, > > > If someone else wants to change it go ahead. I don't know why Jordan > chose a default of no for this. Probably because server's usually > don't have mice. > And people installing servers are usually more savvy about picking through install options than people installing on the desktop. > >>2) allow ubsd to be toggled in the 'Startup Services' menu, with the >>default to TRUE. Hell, usbd isn't nearly as annoying as sendmail! > > > Well, the default should be whatever sysinstall currently detects. It > could be added to the menu easily enough. Oh, wait, it's already > there, and has been for about a year and a half: > > revision 1.322 > date: 2001/09/05 00:58:28; author: murray; state: Exp; lines: +5 -1 > Allow users to enable usbd and set flags from sysinstall. This is > useful for post install configuration or other cases that might not be > handled by usb.c. (usb.c already sets usbd_enable iff sysinstall > detects usb during install). > > PR: bin/18946 > Submitted by: Peter van Heusden > Reviewed by: jhb > Ok, I have no idea why I kept on missing this.