From owner-cvs-all  Wed Dec 13  5:35:10 2000
From owner-cvs-all@FreeBSD.ORG  Wed Dec 13 05:35:08 2000
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5021A37B400; Wed, 13 Dec 2000 05:35:05 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.8.7/8.8.7) with ESMTP id AAA08226;
	Thu, 14 Dec 2000 00:35:01 +1100
Date: Thu, 14 Dec 2000 00:35:00 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: John Baldwin <jhb@FreeBSD.org>
Cc: Matthew Jacob <mjacob@feral.com>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org, Peter Jeremy <peter.jeremy@alcatel.com.au>
Subject: Re: cvs commit: src/sys/sys kernel.h eventhandler.h src/sys/kern
In-Reply-To: <XFMail.001212130500.jhb@FreeBSD.org>
Message-ID: <Pine.BSF.4.21.0012140017550.2238-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Tue, 12 Dec 2000, John Baldwin wrote:

> On 12-Dec-00 Matthew Jacob wrote:
> > 
> >> I wasn't sure if this breakage had been seen by anyone else.  The fix is to
> >> have agp include sys/proc.h.  I'll commit in a second..
> > 
> > I believe the issue here is that poul *removed* sys/proc.h (from this and
> > tty_cons.c).
> 
> It was hidden because sys/mutex.h includes sys/proc.h, and sys/eventhandler.h
> used to include sys/mutex.h.  Blech.

It's more blecherous than that.  <sys/mutex.h> doesn't include <sys/proc.h>.
It includes <machine/globals.h>.  <machine/globals.h> is supposed to be
included nested but isn't properly designed for this.

Bruce



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message