From owner-freebsd-current@FreeBSD.ORG  Tue Jun 16 13:36:44 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A9C801065672
	for <current@freebsd.org>; Tue, 16 Jun 2009 13:36:44 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (77-93-215-190.static.masterinter.net [77.93.215.190])
	by mx1.freebsd.org (Postfix) with ESMTP id 6489B8FC14
	for <current@freebsd.org>; Tue, 16 Jun 2009 13:36:43 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from localhost (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id E18EF9CB053
	for <current@freebsd.org>; Tue, 16 Jun 2009 15:36:38 +0200 (CEST)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by localhost (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 73OZ4KclqWUy for <current@freebsd.org>;
	Tue, 16 Jun 2009 15:36:36 +0200 (CEST)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id AFA549CB118
	for <current@freebsd.org>; Tue, 16 Jun 2009 15:36:36 +0200 (CEST)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.14.3/8.14.3/Submit) id n5GDaaRo059615
	for current@freebsd.org; Tue, 16 Jun 2009 15:36:36 +0200 (CEST)
	(envelope-from rdivacky)
Date: Tue, 16 Jun 2009 15:36:36 +0200
From: Roman Divacky <rdivacky@freebsd.org>
To: current@freebsd.org
Message-ID: <20090616133636.GA59523@freebsd.org>
References: <20090615211123.GA88422@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090615211123.GA88422@freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: 
Subject: Re: [PATCH]: typo in contrib/ipf
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 16 Jun 2009 13:36:45 -0000

I just commited the fix. it is worth to note that this bug
was found by clang. The wider warnings seems to be quite
useful to me....


On Mon, Jun 15, 2009 at 11:11:23PM +0200, Roman Divacky wrote:
> hi
> 
> I found this typo:
> 
> 
> Index: tools/ipfcomp.c
> ===================================================================
> RCS file: /home/ncvs/src/contrib/ipfilter/tools/ipfcomp.c,v
> retrieving revision 1.5
> diff -u -r1.5 ipfcomp.c
> --- tools/ipfcomp.c	4 Jun 2007 02:54:34 -0000	1.5
> +++ tools/ipfcomp.c	15 Jun 2009 21:10:14 -0000
> @@ -382,7 +382,7 @@
>  extern frentry_t *ipf_rules_out_%s[%d];\n",
>  			grp->fg_name, grp->fg_name, outcount);
>  
> -		for (g = groups; g != g; g = g->fg_next)
> +		for (g = groups; g != grp; g = g->fg_next)
>  			if ((strncmp(g->fg_name, grp->fg_name,
>  				     FR_GROUPLEN) == 0) &&
>  			    g->fg_flags == grp->fg_flags)
> 
> can someone review it? darren reed ignored my mail. is it ok
> to commit to contrib/ipf ?
> 
> thnx for the answers :)
> 
> roman
>