From owner-svn-src-all@FreeBSD.ORG Wed Feb 13 17:58:29 2013 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id BF50F8EF; Wed, 13 Feb 2013 17:58:29 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from duck.symmetricom.us (duck.symmetricom.us [206.168.13.214]) by mx1.freebsd.org (Postfix) with ESMTP id 8074E61B; Wed, 13 Feb 2013 17:58:29 +0000 (UTC) Received: from damnhippie.dyndns.org (daffy.symmetricom.us [206.168.13.218]) by duck.symmetricom.us (8.14.6/8.14.6) with ESMTP id r1DHwSQ0002341; Wed, 13 Feb 2013 10:58:28 -0700 (MST) (envelope-from ian@FreeBSD.org) Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id r1DHwQHu042555; Wed, 13 Feb 2013 10:58:26 -0700 (MST) (envelope-from ian@FreeBSD.org) Subject: Re: svn commit: r246763 - in head: lib/libc/sys sys/kern From: Ian Lepore To: Benjamin Kaduk In-Reply-To: References: <201302131509.r1DF9GdM011497@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" Date: Wed, 13 Feb 2013 10:58:26 -0700 Message-ID: <1360778306.4545.219.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2013 17:58:29 -0000 On Wed, 2013-02-13 at 11:24 -0500, Benjamin Kaduk wrote: > On Wed, Feb 13, 2013 at 10:09 AM, Ian Lepore wrote: > > > Author: ian > > Date: Wed Feb 13 15:09:16 2013 > > New Revision: 246763 > > URL: http://svnweb.freebsd.org/changeset/base/246763 > > > > Modified: head/lib/libc/sys/fcntl.2 > > > > ============================================================================== > > --- head/lib/libc/sys/fcntl.2 Wed Feb 13 14:57:54 2013 (r246762) > > +++ head/lib/libc/sys/fcntl.2 Wed Feb 13 15:09:16 2013 (r246763) > > @@ -171,7 +171,7 @@ argument, > > which is rounded up to the nearest block size. > > A zero value in > > .Fa arg > > -turns off read ahead. > > +turns off read ahead, a negative value restores the system default. > > > > Comma splice? Perhaps. The two clauses are independent in the grammatical sense, but conceptually not so much. I had initially written a semicolon, but then I pondered and changed it, mainly because I tend to over-use semicolons, so I often reflexively remove them if I stop to think about it. My concern was keeping the second occurance of the word "value" conceptually coupled with the first use of it in the sentence; that's why I didn't use a separate sentence. Do you think a semicolon is better? -- Ian