From owner-trustedbsd-cvs@FreeBSD.ORG Thu Aug 24 17:37:54 2006 Return-Path: X-Original-To: trustedbsd-cvs@freebsd.org Delivered-To: trustedbsd-cvs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 96ECA16A4DA for ; Thu, 24 Aug 2006 17:37:54 +0000 (UTC) (envelope-from owner-perforce@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 03B6143D4C for ; Thu, 24 Aug 2006 17:37:53 +0000 (GMT) (envelope-from owner-perforce@freebsd.org) Received: from mx2.freebsd.org (mx2.freebsd.org [216.136.204.119]) by cyrus.watson.org (Postfix) with ESMTP id 27B9846C5E for ; Thu, 24 Aug 2006 13:37:52 -0400 (EDT) Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id 6E7F9576CA; Thu, 24 Aug 2006 17:36:50 +0000 (GMT) (envelope-from owner-perforce@freebsd.org) Received: by hub.freebsd.org (Postfix, from userid 32767) id 569D116A4E7; Thu, 24 Aug 2006 17:36:50 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1AA0516A4DD for ; Thu, 24 Aug 2006 17:36:50 +0000 (UTC) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id D0D4A43D46 for ; Thu, 24 Aug 2006 17:36:49 +0000 (GMT) (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7OHanbq019533 for ; Thu, 24 Aug 2006 17:36:49 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7OHanBH019530 for perforce@freebsd.org; Thu, 24 Aug 2006 17:36:49 GMT (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org) Date: Thu, 24 Aug 2006 17:36:49 GMT Message-Id: <200608241736.k7OHanBH019530@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f From: Robert Watson To: Perforce Change Reviews Cc: Subject: PERFORCE change 104963 for review X-BeenThere: trustedbsd-cvs@FreeBSD.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: TrustedBSD CVS and Perforce commit message list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Aug 2006 17:37:54 -0000 http://perforce.freebsd.org/chv.cgi?CH=104963 Change 104963 by rwatson@rwatson_sesame on 2006/08/24 17:35:48 Add a comment about an API usability problem relating to our whole record read model, which may cause problems when combining a series of long records with a short buffer and an event model. Affected files ... .. //depot/projects/trustedbsd/audit3/sys/security/audit/audit_pipe.c#27 edit Differences ... ==== //depot/projects/trustedbsd/audit3/sys/security/audit/audit_pipe.c#27 (text+ko) ==== @@ -912,6 +912,13 @@ * records that would be truncated if actually passed to the * process. This helps maintain the discreet record read * interface. + * + * XXXRW: This causes a somewhat tricky problem when a + * program checks for readability using kqueue/select/poll, + * then provides too small a buffer to hold any of the + * available records. We should probably, in that situation, + * also return EAGAIN rather than blocking unconditionally, + * or possible even an error each time a record is dropped. */ while ((ape = audit_pipe_pop(ap)) == NULL) { if (ap->ap_flags & AUDIT_PIPE_NBIO) {