From owner-freebsd-bugs@FreeBSD.ORG  Thu Dec 14 04:55:09 2006
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 534DF16A47C;
	Thu, 14 Dec 2006 04:55:09 +0000 (UTC)
	(envelope-from rodrigc@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 2505F43CC6;
	Thu, 14 Dec 2006 04:53:36 +0000 (GMT)
	(envelope-from rodrigc@FreeBSD.org)
Received: from freefall.freebsd.org (rodrigc@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id kBE4t83O018211;
	Thu, 14 Dec 2006 04:55:08 GMT
	(envelope-from rodrigc@freefall.freebsd.org)
Received: (from rodrigc@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id kBE4t8jZ018207;
	Thu, 14 Dec 2006 04:55:08 GMT (envelope-from rodrigc)
Date: Thu, 14 Dec 2006 04:55:08 GMT
From: Craig Rodrigues <rodrigc@FreeBSD.org>
Message-Id: <200612140455.kBE4t8jZ018207@freefall.freebsd.org>
To: eugen@grosbein.pp.ru, rodrigc@FreeBSD.org, freebsd-bugs@FreeBSD.org,
	rodrigc@FreeBSD.org
Cc: 
Subject: Re: bin/105412: [patch] mount(8): msdosfs mounted as r/o cannot be
	remounted to r/w
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Dec 2006 04:55:09 -0000

Synopsis: [patch] mount(8): msdosfs mounted as r/o cannot be remounted to r/w

State-Changed-From-To: open->patched
State-Changed-By: rodrigc
State-Changed-When: Thu Dec 14 04:48:52 UTC 2006
State-Changed-Why: 
Very nice testcase.  I made a shell script for it:

#!/bin/sh
dd if=/dev/zero bs=1k count=1440 of=image.msdos
mdconfig -a -t vnode -f image.msdos
newfs_msdos -f 1440 /dev/md0
mount_msdosfs -o ro /dev/md0 /mnt
mount | grep md0
mount -u -o rw /dev/md0; echo $?
mount | grep md0

Take a look at src/sys/fs/msdosfs/msdosfs_vfsops.c version 1.144.2.7.
For me, that makes your testcase pass on RELENG_6.

The patch that you posted for mount(8) is only used for
"mount -a", so doesn't handle your testcase.


Responsible-Changed-From-To: freebsd-bugs->rodrigc
Responsible-Changed-By: rodrigc
Responsible-Changed-When: Thu Dec 14 04:48:52 UTC 2006
Responsible-Changed-Why: 
Very nice testcase.  I made a shell script for it:

#!/bin/sh
dd if=/dev/zero bs=1k count=1440 of=image.msdos
mdconfig -a -t vnode -f image.msdos
newfs_msdos -f 1440 /dev/md0
mount_msdosfs -o ro /dev/md0 /mnt
mount | grep md0
mount -u -o rw /dev/md0; echo $?
mount | grep md0

Take a look at src/sys/fs/msdosfs/msdosfs_vfsops.c version 1.144.2.7.
For me, that makes your testcase pass on RELENG_6.

The patch that you posted for mount(8) is only used for
"mount -a", so doesn't handle your testcase.

http://www.freebsd.org/cgi/query-pr.cgi?pr=105412