From owner-freebsd-ports@FreeBSD.ORG  Fri Feb 10 18:29:35 2012
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 08ACE106566C;
	Fri, 10 Feb 2012 18:29:35 +0000 (UTC) (envelope-from max@mxcrypt.com)
Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com
	[209.85.210.54])
	by mx1.freebsd.org (Postfix) with ESMTP id C28CE8FC15;
	Fri, 10 Feb 2012 18:29:34 +0000 (UTC)
Received: by daec6 with SMTP id c6so3139091dae.13
	for <multiple recipients>; Fri, 10 Feb 2012 10:29:34 -0800 (PST)
Received: by 10.68.218.231 with SMTP id pj7mr18854180pbc.63.1328898574614;
	Fri, 10 Feb 2012 10:29:34 -0800 (PST)
MIME-Version: 1.0
Received: by 10.142.178.12 with HTTP; Fri, 10 Feb 2012 10:29:04 -0800 (PST)
In-Reply-To: <CAJcQMWf3NXt1Bn=qXxsqa5ZTOnZ=R0xPAALNRfT8bTWQkhLaiA@mail.gmail.com>
References: <CAJcQMWf3NXt1Bn=qXxsqa5ZTOnZ=R0xPAALNRfT8bTWQkhLaiA@mail.gmail.com>
From: Maxim Khitrov <max@mxcrypt.com>
Date: Fri, 10 Feb 2012 13:29:04 -0500
Message-ID: <CAJcQMWegXp6jd8E2nc7=uhHp9EB7hwQFRutmjsG3VTCcRy9=_w@mail.gmail.com>
To: freebsd-ports@freebsd.org, Alex Dupre <ale@freebsd.org>
Content-Type: text/plain; charset=UTF-8
X-Gm-Message-State: ALoCoQnOFQovtdan6i1Uo0MBWYSle8n5UkkAFwNymYMcmjhObxfz8vC1VMmrwYCiYj8UWOPh+avM
Cc: 
Subject: Re: Requested changes to lang/php5 port
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 10 Feb 2012 18:29:35 -0000

On Fri, Feb 10, 2012 at 12:41 PM, Maxim Khitrov <max@mxcrypt.com> wrote:
> Hello,
>
> I'd like to request two minor changes to the lang/php5 port:
>
> 1. Change 'CONFIGURE_ARGS=' line to 'CONFIGURE_ARGS+=' to allow
> customizations to the arguments. One reason for this is that some
> extensions, like security/php5-hash, have to be compiled into the
> core. Otherwise, 'session.hash_function' option cannot use hash
> algorithms offered by that extension. See the following bug report for
> more info:
>
> https://bugs.php.net/bug.php?id=53789
>
> 2. Unless there is a very good reason for keeping them, I think
> '--enable-libxml' and especially '--enable-mysqlnd' should be removed
> from the default set of arguments. Make these two part of the options
> dialog, if you want, but there are plenty of installations that have
> no need for any MySQL or XML functionality. Why compile these into the
> core by default?

Actually, I now realize that changing 'CONFIGURE_ARGS=' to
'CONFIGURE_ARGS+=' wouldn't help me, because --disable-all would
negate --enable-hash, which I was planning to specify.

What would be the best way of passing custom --enable-X arguments to
CONFIGURE_ARGS after --disable-all is set?

As for removing --enable-libxml, it seems to be required when building
the port (maybe for fpm?), but --enable-mysqlnd should definitely be
removed by default.

- Max