From owner-cvs-all@FreeBSD.ORG Tue Feb 21 09:04:09 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4286416A420; Tue, 21 Feb 2006 09:04:09 +0000 (GMT) (envelope-from morten@burton.rodal.no) Received: from osl1smout1.broadpark.no (osl1smout1.broadpark.no [80.202.4.58]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A54C43D45; Tue, 21 Feb 2006 09:04:08 +0000 (GMT) (envelope-from morten@burton.rodal.no) Received: from osl1sminn1.broadpark.no ([80.202.4.59]) by osl1smout1.broadpark.no (Sun Java System Messaging Server 6.1 HotFix 0.05 (built Oct 21 2004)) with ESMTP id <0IV100AYZ56LBL90@osl1smout1.broadpark.no>; Tue, 21 Feb 2006 10:03:58 +0100 (CET) Received: from slimy.rodal.no ([84.48.98.26]) by osl1sminn1.broadpark.no (Sun Java System Messaging Server 6.1 HotFix 0.05 (built Oct 21 2004)) with ESMTP id <0IV100MGN560WLA0@osl1sminn1.broadpark.no>; Tue, 21 Feb 2006 10:03:36 +0100 (CET) Received: from burton.rodal.no (burton.rodal.no [192.168.20.70]) by slimy.rodal.no (8.13.1/8.13.1) with ESMTP id k1L93ZvS052372; Tue, 21 Feb 2006 10:03:35 +0100 (CET envelope-from morten@burton.rodal.no) Received: (from morten@localhost) by burton.rodal.no (8.13.4/8.13.4/Submit) id k1L91h5n034381; Tue, 21 Feb 2006 10:01:43 +0100 (CET envelope-from morten) Date: Tue, 21 Feb 2006 10:01:43 +0100 From: Morten Rodal In-reply-to: <200602151345.k1FDj2Aq013830@repoman.freebsd.org> To: Gleb Smirnoff Message-id: <20060221090143.GB33896@burton.rodal.no> MIME-version: 1.0 Content-type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary=0eh6TmSyL6TZE2Uz Content-disposition: inline X-Original-Status: RO X-Virus-Scanned: by amavisd-new References: <200602151345.k1FDj2Aq013830@repoman.freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/em if_em.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2006 09:04:09 -0000 --0eh6TmSyL6TZE2Uz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 15, 2006 at 01:45:02PM +0000, Gleb Smirnoff wrote: > glebius 2006-02-15 13:45:02 UTC >=20 > FreeBSD src repository >=20 > Modified files: > sys/dev/em if_em.c=20 > Log: > em_hardware_init() in em_init() is not needed, and leads to annoying > link flap. > =20 > Submitted by: ru, Mike Tancsa > =20 > Revision Changes Path > 1.112 +0 -7 src/sys/dev/em/if_em.c This change breaks the network interfaces in vmware 5.5 on amd64. I also attempted to build a module with NO_EM_FASTINTR defined, but that did not help either. The change in 1.113 has no effect either. Reverting the em_hardware_init() change works, even without the em_update_link_status(). --=20 Morten Rodal "A supercomputer is a device for turning compute-bound problems into I/O bound problems." -- Ken Batcher (Goodyear Aerospace) --0eh6TmSyL6TZE2Uz Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFD+tb3bWe1Cy11WVsRAsfzAJoDC67vpIctvYaDCSdBF688/nARoACdEnMF 0PgNEpThj06BYXKnMV/pKrY= =volQ -----END PGP SIGNATURE----- --0eh6TmSyL6TZE2Uz--