From owner-freebsd-arch Fri Sep 28 16:54:23 2001 Delivered-To: freebsd-arch@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id 33BCD37B40E for ; Fri, 28 Sep 2001 16:54:19 -0700 (PDT) Received: (qmail 54639 invoked from network); 28 Sep 2001 23:54:18 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 28 Sep 2001 23:54:18 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20010928233146.8959B3809@overcee.netplex.com.au> Date: Fri, 28 Sep 2001 16:54:01 -0700 (PDT) From: John Baldwin To: Peter Wemm Subject: Re: Style Wars Cc: arch@FreeBSD.ORG, Warner Losh , Julian Elischer Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 28-Sep-01 Peter Wemm wrote: > John Baldwin wrote: >> [ moved to -arch ] >> >> On 28-Sep-01 Julian Elischer wrote: >> > well maybe We can come up with a tweek to the standard that we can >> > all agree to... >> > and commit.. It is after all a 'living' document.. >> >> Certainly a viable option. I've seen a couple of ideas so far: >> >> 1) Use two tabs instead of one when types longer than one tab such >> as u_int64_t are used. >> 1a) Same as 1) but the tabs after after the type, not just the >> first word. > > 1b) Same as 1a), but also with 2) for types longer than two tabs. > ie: "struct verylongtypename *foo;" > >> 2) Use a space instead of a tab after types longer than one tab like >> we already do for queue macros. I'm think 1b) is the one most people have favored so far and it is rather close to our existing style, so it's not that big of a change. Does anyone object to 1b)? It basically results in the following changes: use 2 tab spaces instead of 1 for type names, put the entire type name before the tab(s), and if the type is too long, just use a space. > 1b) > > struct foo { > int f_type; > struct mtx f_lock; > const char *f_name; > volatile int f_int; > u_int64_t f_64; > const volatile char f_cv; > TAILQ_ENTRY(foo) f_link; > }; -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message