From owner-freebsd-current@FreeBSD.ORG  Tue Sep 22 20:09:17 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3B59A1065672;
	Tue, 22 Sep 2009 20:09:17 +0000 (UTC)
	(envelope-from wblock@wonkity.com)
Received: from wonkity.com (wonkity.com [67.158.26.137])
	by mx1.freebsd.org (Postfix) with ESMTP id 8C5148FC1D;
	Tue, 22 Sep 2009 20:09:16 +0000 (UTC)
Received: from wonkity.com (localhost [127.0.0.1])
	by wonkity.com (8.14.3/8.14.3) with ESMTP id n8MK9FSQ010545;
	Tue, 22 Sep 2009 14:09:15 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
Received: from localhost (wblock@localhost)
	by wonkity.com (8.14.3/8.14.3/Submit) with ESMTP id n8MK9Enf010542;
	Tue, 22 Sep 2009 14:09:14 -0600 (MDT)
	(envelope-from wblock@wonkity.com)
Date: Tue, 22 Sep 2009 14:09:14 -0600 (MDT)
From: Warren Block <wblock@wonkity.com>
To: Jaakko Heinonen <jh@saunalahti.fi>
In-Reply-To: <20090922115106.GA2856@a91-153-125-115.elisa-laajakaista.fi>
Message-ID: <alpine.BSF.2.00.0909221406560.10526@wonkity.com>
References: <alpine.BSF.2.00.0909202116520.3416@lightning.wonkity.com>
	<19e9a5dc0909202237g1295b6d9hf69012745009eef4@mail.gmail.com>
	<20090921105458.GA86764@melamine.cuivre.fr.eu.org>
	<alpine.BSF.2.00.0909210723520.3607@wonkity.com>
	<20090922115106.GA2856@a91-153-125-115.elisa-laajakaista.fi>
User-Agent: Alpine 2.00 (BSF 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2
	(wonkity.com [127.0.0.1]); Tue, 22 Sep 2009 14:09:15 -0600 (MDT)
Cc: freebsd-current@freebsd.org, Gonzalo Nemmi <gnemmi@gmail.com>,
	avg@freebsd.org, Thomas Quinot <thomas@freebsd.org>
Subject: Re: core dump on kldload atapicam
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Sep 2009 20:09:17 -0000

On Tue, 22 Sep 2009, Jaakko Heinonen wrote:

> On 2009-09-21, Warren Block wrote:
>>>> I can confirm that .. kldload atapicam still results in a "Fatal trap 12:
>>>> page fault while in kernel mode" on 8.0-RC1
>
> The problem was introduced in r195534. Does the following patch work for
> you?
>
> %%%
> Index: sys/dev/ata/atapi-cam.c
> ===================================================================
> --- sys/dev/ata/atapi-cam.c	(revision 197399)
> +++ sys/dev/ata/atapi-cam.c	(working copy)
> @@ -418,8 +418,10 @@ atapi_action(struct cam_sim *sim, union
> 		break;
> 	    }
> 	}
> -	cpi->maxio = softc->ata_ch->dma.max_iosize ?
> -	    softc->ata_ch->dma.max_iosize : DFLTPHYS;
> +	if (softc->ata_ch != NULL && softc->ata_ch->dma.max_iosize != 0)
> +	    cpi->maxio = softc->ata_ch->dma.max_iosize;
> +	else
> +	    cpi->maxio = DFLTPHYS;
> 	ccb->ccb_h.status = CAM_REQ_CMP;
> 	xpt_done(ccb);
> 	return;
> %%%

Yes!  kldload atapicam is fine, as is loading it in /boot/loader.conf. 
Thank you.

-Warren Block * Rapid City, South Dakota USA