From owner-svn-src-all@FreeBSD.ORG Sun Sep 13 16:12:34 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 51B90106566C; Sun, 13 Sep 2009 16:12:34 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from kennaway-macbookpro.config (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 5C73C8FC14; Sun, 13 Sep 2009 16:12:33 +0000 (UTC) Message-ID: <4AAD19F2.10005@FreeBSD.org> Date: Sun, 13 Sep 2009 17:12:34 +0100 From: Kris Kennaway User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Jung-uk Kim References: <200909112147.n8BLlind064388@svn.freebsd.org> In-Reply-To: <200909112147.n8BLlind064388@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r197102 - head/sys/dev/amdtemp X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Sep 2009 16:12:34 -0000 Jung-uk Kim wrote: > Author: jkim > Date: Fri Sep 11 21:47:44 2009 > New Revision: 197102 > URL: http://svn.freebsd.org/changeset/base/197102 > > Log: > Improve amdtemp(4) significantly: > > - Improve newer AMD processor support (Family 0Fh Revision F and later). > - Adjust offset if DiodeOffet is set and valid. Note it is experimental > but it seems to give us more realistic temperatures. Newer Linux driver > blindly adds 21C for Family 0Fh desktop processors, however. > - Always populate dev.cpu and dev.amdtemp sysctl trees regardless of probe > order for consistency. Previously, dev.cpu.N.temperature was not populated > if amdtemp was loaded later than ACPI CPU driver and temperatures were not > accessible from dev.amdtemp.N.sensor0 tree for Family 10h/11h processors. > - Read the CPUID from PCI register instead of CPUID instruction to prevent > possible revision mismatches on multi-socket system. > - Change macros and variables to make them closer to AMD documents. > - Fix style(9) nits and improve comments. It no longer appears to work for me. The old version reported: dev.amdtemp.0.%desc: AMD K8 Thermal Sensors dev.amdtemp.0.%driver: amdtemp dev.amdtemp.0.%parent: hostb9 dev.amdtemp.0.sensor0.core0: 38.0C dev.amdtemp.0.sensor0.core1: 45.0C dev.amdtemp.0.sensor1.core0: 38.0C dev.amdtemp.0.sensor1.core1: 45.0C dev.cpu.0.temperature: 38.0C dev.cpu.1.temperature: 38.0C but none of those sysctl nodes are now present. CPU: AMD Athlon(tm) 64 X2 Dual Core Processor 4600+ (2400.10-MHz K8-class CPU) Origin = "AuthenticAMD" Id = 0x20f32 Stepping = 2 Features=0x178bfbff Features2=0x1 AMD Features=0xe2500800 AMD Features2=0x3 ACPI APIC Table: