From owner-freebsd-fs@FreeBSD.ORG  Tue Nov 18 17:29:45 2008
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D828D106564A;
	Tue, 18 Nov 2008 17:29:45 +0000 (UTC) (envelope-from avg@icyb.net.ua)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id CA2D68FC14;
	Tue, 18 Nov 2008 17:29:44 +0000 (UTC) (envelope-from avg@icyb.net.ua)
Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua
	[212.40.38.101])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA28886;
	Tue, 18 Nov 2008 19:29:38 +0200 (EET) (envelope-from avg@icyb.net.ua)
Message-ID: <4922FB81.50608@icyb.net.ua>
Date: Tue, 18 Nov 2008 19:29:37 +0200
From: Andriy Gapon <avg@icyb.net.ua>
User-Agent: Thunderbird 2.0.0.17 (X11/20081106)
MIME-Version: 1.0
To: Marcel Moolenaar <xcllnt@mac.com>
References: <4911C3E9.405@icyb.net.ua> <49198A1A.3080600@icyb.net.ua>
	<B6997A5A-1B56-4325-A24A-EF90AF8C6A6A@mac.com>
	<49227875.6090902@icyb.net.ua>
	<93FC5F5D-91CD-450B-B08D-5C5EC5A1C880@mac.com>
In-Reply-To: <93FC5F5D-91CD-450B-B08D-5C5EC5A1C880@mac.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-fs@freebsd.org, freebsd-geom@freebsd.org
Subject: Re: zfs: affected by geom_(mbr|bsd) => geom_part_(mbr|bsd) ?
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Nov 2008 17:29:46 -0000


I just remembered that I saved old zpool.cache file before "migrating"
the pool.
I looked at the diff of hexdumps and there are a number of differences,
it's hard to understand them because the file is binary (actually it
seems to contain serialized name-value pairs), but one difference is
prominent:
...
 00000260  64 65 76 69 64 00 00 00  00 00 00 09 00 00 00 01
|devid...........|
...
-00000270  00 00 00 15 61 64 3a 47  45 41 35 33 34 52 46 30
|....ad:GEA534RF0|
-00000280  54 4b 33 35 41 73 31 73  33 00 00 00 00 00 00 28
|TK35As1s3......(|
...
+00000270  00 00 00 11 61 64 3a 47  45 41 35 33 34 52 46 30
|....ad:GEA534RF0|
+00000280  54 4b 33 35 41 00 00 00  00 00 00 28 00 00 00 28
|TK35A......(...(|
...

It looks like old "devid" value is "ad:GEA534RF0TK35As1s3" and new one
is "ad:GEA534RF0TK35A". Just a reminder: actual zpool device is ad6s2d.

The new value is what is reported by diskinfo:
$ diskinfo -v ad6
ad6
...
        ad:GEA534RF0TK35A       # Disk ident.

$ diskinfo -v ad6s2
ad6s2
...
        ad:GEA534RF0TK35A       # Disk ident.

$ diskinfo -v ad6s2d
ad6s2d
...
        ad:GEA534RF0TK35A       # Disk ident.

Hmm, "indent" is reported to be the same for all three entities.

I don't remember what diskinfo reported with pre-gpart kernel, but I
suspect that it was something different.
Could anybody please check this? (on 7.X machine without GEOM_PART).

I quickly glimpsed through sources and it seems that this comes from
DIOCGIDENT GEOM ioctl i.e. "GEOM::ident" attribute. It seems that
geom_slice.c code has some special handling for that.

-- 
Andriy Gapon