From owner-cvs-all@FreeBSD.ORG Tue Nov 1 14:22:18 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8638716A420; Tue, 1 Nov 2005 14:22:18 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id 509DB43D45; Tue, 1 Nov 2005 14:22:17 +0000 (GMT) (envelope-from bright@elvis.mu.org) Received: by elvis.mu.org (Postfix, from userid 1192) id E3EEF1A3C2D; Tue, 1 Nov 2005 06:22:17 -0800 (PST) Date: Tue, 1 Nov 2005 06:22:17 -0800 From: Alfred Perlstein To: David Xu Message-ID: <20051101142217.GN32289@elvis.mu.org> References: <200510300212.j9U2CnWl089007@repoman.freebsd.org> <20051030134702.GK32289@elvis.mu.org> <43655AF7.8070707@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <43655AF7.8070707@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: alc@freebsd.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys aio.h signal.h signalvar.h src/sys/kern syscalls.master vfs_aio.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Nov 2005 14:22:18 -0000 * David Xu [051030 15:44] wrote: > Existing binary code needn't be recompiled, it should work as before. > if an AIO syscall needs sigevent structure, it already has a new syscall > number, and old syscalls will think passed sigevent is an osigevent. > I am open for adding pad fields to aiocb and sigevent, how many padding > do you want to add, give some diffs for us ? :-) I apologize, I didn't realize that this was actually the compat patch. I have no idea about padding, I just thought it might be a good idea, you might want to check if Sun/Apple/Linux have padding and copy that just for future expansion. But I do not have time to provide that. > > David Xu > > Alfred Perlstein wrote: > > >Does this modify the size/layout of the struct sigevent and aiocb > >to the point where apps need a recompile? If so we > >should we have compat functions for AIO? Ei, struct "osigevent" > >and "oaiocb" and corresponding compat functions for AIO? > > > >I understand that it's annoying but AIO has been an interface around > >since 4.x. > > > >Now might also be a good time to add padding to aiocb and possibly > >sigevent. > > > >-Alfred > > > > -- - Alfred Perlstein