From owner-freebsd-hackers@FreeBSD.ORG  Sun Jul  3 19:49:09 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id E841B1065672;
	Sun,  3 Jul 2011 19:49:09 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from mx0.hoeg.nl (mx0.hoeg.nl [IPv6:2a01:4f8:101:5343::aa])
	by mx1.freebsd.org (Postfix) with ESMTP id 8726D8FC08;
	Sun,  3 Jul 2011 19:49:09 +0000 (UTC)
Received: by mx0.hoeg.nl (Postfix, from userid 1000)
	id 928862A28CCD; Sun,  3 Jul 2011 21:49:08 +0200 (CEST)
Date: Sun, 3 Jul 2011 21:49:08 +0200
From: Ed Schouten <ed@80386.nl>
To: Robert Millan <rmh@debian.org>
Message-ID: <20110703194908.GO71453@hoeg.nl>
References: <CAOfDtXP-vZ=qDKZuw0P7=NwX5BfUpqqvGsLLrVHTjrnaRjcMhQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Wfe1KbQWcwuymTys"
Content-Disposition: inline
In-Reply-To: <CAOfDtXP-vZ=qDKZuw0P7=NwX5BfUpqqvGsLLrVHTjrnaRjcMhQ@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: freebsd-hackers@freebsd.org, Ed Maste <emaste@freebsd.org>
Subject: Re: [PATCH] build config(8) on GNU systems
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Jul 2011 19:49:10 -0000


--Wfe1KbQWcwuymTys
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

* Robert Millan <rmh@debian.org>, 20110702 16:56:
> Index: usr.sbin/config/main.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- usr.sbin/config/main.c	(revision 223721)
> +++ usr.sbin/config/main.c	(working copy)
> @@ -591,7 +591,11 @@
>  	if ((dirp =3D opendir(p)) =3D=3D NULL)
>  		err(EX_OSERR, "opendir %s", p);
>  	while ((dp =3D readdir(dirp)) !=3D NULL) {
> +#ifdef _DIRENT_HAVE_D_NAMLEN
>  		i =3D dp->d_namlen - 2;
> +#else
> +		i =3D strlen (dp->d_name) - 2;
> +#endif
>  		/* Skip non-headers */
>  		if (dp->d_name[i] !=3D '.' || dp->d_name[i + 1] !=3D 'h')
>  			continue;

Why not simply use strlen() unconditionally?

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--Wfe1KbQWcwuymTys
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (FreeBSD)

iQIcBAEBAgAGBQJOEMe0AAoJEG5e2P40kaK7/TcQAKpsL4NeUhq6SAOiK0Zxr+tB
MYBSiu1QMo3+JtXFCKCecEqHPpoXew6o2+daktYxFgpxf2eopLdvXLa88Dh6kJT4
DfpTpUam5runU5U8f3HhLM2liwkHgmRkI6yJGUQAgZVdHriF1lMeNqi6ILI+Tv0U
23t6hJc6GCwz/JG2hKNS/iEyjdHj+JoZqU4VtxMBHIHXaj5aUxQDW1+VK2eSz9s/
XAZbvcZMVMF+ZjcBuYVJs/odYez1pnZxk/xDjmhlCvWOjoO3X7N+4BEyBeaC6jti
NfL/bWjctynpP3e6eFYbTGDFnRA0VaA2gRsUYKaJkLTJN6Fsd/+NcmVMk2+77LmQ
MW2bwz6i6VbVBKRB0ETHkukl7XuHQLrlADzBJTBDjXwZKEIte2qSlnMJ7BOZe5nU
5Rzd/uvr9p7z/wdVUmrVgTj2s+rx4WCffe3OV7HDsOTOaFaXITa6WrSay5RNY1TM
Y/5nIwxHcKLffUt/RktBNaWx6XBBt/2RCYoxVKtOclA+YMEABf0W8Pj1DcKtcGxu
QdhfhIj+F5fq3KEC/6FwTgFUfPuInLbkN2zoiXM5t991QOe2rTCvjgsF9cL8kxGJ
PjPXT1fRKzTOrQigKhPiW4EBNNlmXykxmoO6IWbBhXHRTU1h7dIE74KvERR+rBm1
C4bx9FZh2pEPJgC05cNM
=Mj3D
-----END PGP SIGNATURE-----

--Wfe1KbQWcwuymTys--