From owner-freebsd-fs@FreeBSD.ORG Fri May 15 20:11:22 2009 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6DF1D1065672 for ; Fri, 15 May 2009 20:11:22 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: from mail-ew0-f159.google.com (mail-ew0-f159.google.com [209.85.219.159]) by mx1.freebsd.org (Postfix) with ESMTP id EFCAB8FC18 for ; Fri, 15 May 2009 20:11:21 +0000 (UTC) (envelope-from mat.macy@gmail.com) Received: by ewy3 with SMTP id 3so2589430ewy.43 for ; Fri, 15 May 2009 13:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type:content-transfer-encoding; bh=zPDP7i/paizGaCRN3e+cNsiBmkifWBesZglqwrMJ5pU=; b=APQ8j+W3P+Tt0CCTv119r+fORsI0fcqwn5IM5s262GpjqOVBOncJnwhKL4q5zF8nUh /MeY9qdgQMJhNGlVV/SRHfeH452kCve+af030SyT491aeZ/L3CC3j7xbzUSFsP2RwBHd wEprnXquaJB2uNE6tXgR8V8V+QFsVUCjbO7P0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=JTP5i6FkN9yahl8H+Dr0WfIkV6DWnUZlFazbm23YQDAvo5d3CW4Is4BTOKrW+xeXUR XeC5Il09BMBciMO4eyG+8GLZP1g9Hlig4UOnZv5PCn3OKbgOTzTWdsSBFBeYag3Jz0z4 51KiMKJk6SsrWVH3PGGI6DoniQcCCfbf5lElg= MIME-Version: 1.0 Sender: mat.macy@gmail.com Received: by 10.216.70.205 with SMTP id p55mr1341312wed.55.1242418280828; Fri, 15 May 2009 13:11:20 -0700 (PDT) In-Reply-To: <4A0D6276.2080902@icyb.net.ua> References: <4A0D48CB.7030707@icyb.net.ua> <4A0D5E64.1050500@icyb.net.ua> <4A0D6276.2080902@icyb.net.ua> Date: Fri, 15 May 2009 13:11:20 -0700 X-Google-Sender-Auth: 88e4d0217bf1e833 Message-ID: <3c1674c90905151311jc3cc9a8jb60eb526d849a616@mail.gmail.com> From: Kip Macy To: Andriy Gapon Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-fs@freebsd.org Subject: Re: stable/7: shutdown stuck in zfs_umount (z_op_cnt > 0) X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 May 2009 20:11:22 -0000 On Fri, May 15, 2009 at 5:39 AM, Andriy Gapon wrote: > on 15/05/2009 15:21 Andriy Gapon said the following: >> Red herring or not (I don't see the general picture of zfs code), but it seems >> that there is no ZFS_EXIT for return at the end of zfsctl_snapdir_lookup function. >> >> P.S. C++ RAII could have been handy in this case [or not] :-) > > Couple of notes: > 1. this doesn't appear to be a red herring as ZFS_EXIT before the last return > statement can be found in head > 2. yes, I do mount snapshots from time to time (backups, etc) > Thanks for the bug reports. Unfortunately, pjd is very busy and I do not intend to track down bugs in a very old version of ZFS. Your best bet will be to test the MFC patch when it is ready in a day or two. Cheers, Kip