From owner-svn-src-all@FreeBSD.ORG Wed Apr 15 18:06:02 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7ED181065677; Wed, 15 Apr 2009 18:06:02 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: from kientzle.com (kientzle.com [66.166.149.50]) by mx1.freebsd.org (Postfix) with ESMTP id 4E3668FC29; Wed, 15 Apr 2009 18:06:02 +0000 (UTC) (envelope-from kientzle@freebsd.org) Received: (from root@localhost) by kientzle.com (8.14.3/8.14.3) id n3FI5wOf097871; Wed, 15 Apr 2009 11:05:58 -0700 (PDT) (envelope-from kientzle@freebsd.org) Received: from dark.x.kientzle.com (fw2.kientzle.com [10.123.1.2]) by kientzle.com with SMTP id wwm457v32mhaqzcmyfpdrqykd2; Wed, 15 Apr 2009 11:05:58 -0700 (PDT) (envelope-from kientzle@freebsd.org) Message-ID: <49E62206.2070706@freebsd.org> Date: Wed, 15 Apr 2009 11:05:58 -0700 From: Tim Kientzle User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.8.1.21) Gecko/20090409 SeaMonkey/1.1.15 MIME-Version: 1.0 To: Edward Tomasz Napierala References: <200904141139.n3EBdudA004806@svn.freebsd.org> <49E4D2BF.2040503@freebsd.org> <20090415083103.GA23062@pin.if.uz.zgora.pl> In-Reply-To: <20090415083103.GA23062@pin.if.uz.zgora.pl> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r191055 - head/lib/libc/string X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2009 18:06:03 -0000 Edward Tomasz Napierala wrote: > On 0414T1115, Tim Kientzle wrote: >>> There is no way for strmode(3) to append '+' if the file has ACL, >>> because there is no way to figure that out based on the file mode >>> itself. Make the manual page match reality. >> Yep, that '+' is why libarchive has a custom strmode() >> that accepts more information than just the mode. >> >> A related issue: It would be really nice to be >> able to find out whether a file had extended ACLs >> or extended attributes based on the information >> returned from stat(2). > > I know about the idea of adding a bit to the inode flags, but I never > thought about exposing it to the userland in mode_t. Can we actually > do this without risking confusing some applications that expect only > the standard mode bits to be set? Unfortunately, mode_t is very full and extending it would probably cause chaos. I was thinking of a bit in the fflags field. That wouldn't help strmode(), of course, but would make it easy for strmode() users (such as ls) to add a '+' if they wanted to. Tim