From owner-freebsd-current@FreeBSD.ORG Fri Aug 21 20:10:13 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 45852106568C for ; Fri, 21 Aug 2009 20:10:13 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (skuns.zoral.com.ua [91.193.166.194]) by mx1.freebsd.org (Postfix) with ESMTP id B0F938FC13 for ; Fri, 21 Aug 2009 20:10:12 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id n7LK9wSC050471 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 21 Aug 2009 23:09:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3) with ESMTP id n7LK9wg3004408; Fri, 21 Aug 2009 23:09:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.3/8.14.3/Submit) id n7LK9vxT004407; Fri, 21 Aug 2009 23:09:57 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 21 Aug 2009 23:09:57 +0300 From: Kostik Belousov To: Rick Macklem Message-ID: <20090821200957.GC9623@deviant.kiev.zoral.com.ua> References: <20090819161817.GA89704@keira.kiwi-computer.com> <20090819175029.GA90205@keira.kiwi-computer.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="rKOd0RGqnoxbj4so" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: "Rick C. Petty" , bzeeb+freebsd+lor@zabbadoz.net, current@freebsd.org Subject: Re: various vfs LORs X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Aug 2009 20:10:13 -0000 --rKOd0RGqnoxbj4so Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 21, 2009 at 02:05:13PM -0400, Rick Macklem wrote: >=20 >=20 > On Wed, 19 Aug 2009, Rick C. Petty wrote: >=20 > > > >This LOR doesn't seem to be reported anywhere: > > > >>lock order reversal: > >> 1st 0xffffff00046de7f8 nfs (nfs) @ /usr/src/sys/kern/vfs_syscalls.c:40= 97 > >> 2nd 0xffffff80a5129968 bufwait (bufwait) @=20 > >> /usr/src/sys/kern/vfs_bio.c:1835 > >> 3rd 0xffffff00046de620 nfs (nfs) @ /usr/src/sys/nfsclient/nfs_node.c:1= 61 > >>KDB: stack backtrace: > >>db_trace_self_wrapper() at db_trace_self_wrapper+0x2a > >>_witness_debugger() at _witness_debugger+0x2e > >>witness_checkorder() at witness_checkorder+0x81e > >>__lockmgr_args() at __lockmgr_args+0xcf3 > >>nfs_nget() at nfs_nget+0x1c9 > >>nfs_readdirplusrpc() at nfs_readdirplusrpc+0x7cc > >>nfs_doio() at nfs_doio+0x617 > >>nfs_bioread() at nfs_bioread+0xa9f > >>nfs_readdir() at nfs_readdir+0x85 > >>kern_getdirentries() at kern_getdirentries+0x12e > >>getdirentries() at getdirentries+0x23 > >>syscall() at syscall+0x1af > >>Xfast_syscall() at Xfast_syscall+0xe1 > >>--- syscall (196, FreeBSD ELF64, getdirentries), rip =3D 0x8009d11dc, r= sp =3D=20 > >>0x7fffffffc3a8, rbp =3D 0x1 --- >=20 > Since the 3rd one is locking a newly allocated nfs vnode (that isn't yet= =20 > in the mount point list, etc), I don't think this will cause a problem > and I don't see an easy way to avoid it. We could add LK_NOWITNESS to nfsclient/nfs_subr.c:161. --rKOd0RGqnoxbj4so Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEARECAAYFAkqO/xUACgkQC3+MBN1Mb4j9iwCgiUQjQ7JZ1HFrBQmn4tSAluMQ ZjsAn24tzN3T7UY0uUU+gaRrICw3NQFq =t1dS -----END PGP SIGNATURE----- --rKOd0RGqnoxbj4so--