From owner-freebsd-arch@FreeBSD.ORG Tue Aug 31 20:39:18 2004 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A5F3C16A4CE; Tue, 31 Aug 2004 20:39:18 +0000 (GMT) Received: from odin.ac.hmc.edu (Odin.AC.HMC.Edu [134.173.32.75]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7A98A43D62; Tue, 31 Aug 2004 20:39:18 +0000 (GMT) (envelope-from brdavis@odin.ac.hmc.edu) Received: from odin.ac.hmc.edu (localhost.localdomain [127.0.0.1]) by odin.ac.hmc.edu (8.13.0/8.13.0) with ESMTP id i7VKdTtP030882; Tue, 31 Aug 2004 13:39:29 -0700 Received: (from brdavis@localhost) by odin.ac.hmc.edu (8.13.0/8.13.0/Submit) id i7VKdTvi030881; Tue, 31 Aug 2004 13:39:29 -0700 Date: Tue, 31 Aug 2004 13:39:29 -0700 From: Brooks Davis To: Scott Long Message-ID: <20040831203929.GB25134@odin.ac.hmc.edu> References: <4134DF35.7070605@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3uo+9/B/ebqu+fSQ" Content-Disposition: inline In-Reply-To: <4134DF35.7070605@freebsd.org> User-Agent: Mutt/1.4.1i X-Virus-Scanned: by amavisd-new X-Spam-Status: No, hits=0.0 required=8.0 tests=none autolearn=no version=2.63 X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on odin.ac.hmc.edu cc: Sam cc: freebsd-arch@freebsd.org Subject: Re: option directive and turning on AOE X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Aug 2004 20:39:18 -0000 --3uo+9/B/ebqu+fSQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 31, 2004 at 02:27:33PM -0600, Scott Long wrote: > Sam wrote: >=20 > >I've added code to if_ethersubr.c:/ether_demux/ > >to queue up AoE frames as they appear. I followed > >suit with other protocols and included my addition > >inside of an #ifdef AOE. Where do I turn this on? > >I thought perhaps just adding an 'option AOE' to > >the config would do it, but it doesn't -- so clearly > >I don't understand how the option directive works. > >The config man page doesn't talk about option/device > >directives ... > > > >I'm still looking, but a clue would be well received. >=20 > Did you modify /sys/conf/options to tell it about your > AOE option? If so, then you should have specified the name > of a header file that the option would be #define'd into. > Include that header file in if_ethersubr.c and you should > have no problems. >=20 > Incidentally, this might be an area when netgraph would be > useful. Instead of having an AoE specific hook in the > stack, you could have an AoE netgraph module that uses the > existing netgraph hooks. It's just an idea, though. Another option might be a PFIL hook. There isn't one there now, but I think I've seen talk of adding one. Actually, if we did that, we could get most of the netgraph specific hooks out of the ethernet code. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --3uo+9/B/ebqu+fSQ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBNOIAXY6L6fI4GtQRAg5YAJ4lEaezZpnR+/CNR3tFJfataDutZgCfc64w OyOVBAkHghcChKKcdERpw+w= =fL4C -----END PGP SIGNATURE----- --3uo+9/B/ebqu+fSQ--