From owner-freebsd-mips@FreeBSD.ORG  Wed May 26 07:32:26 2010
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3C8C11065676
	for <freebsd-mips@freebsd.org>; Wed, 26 May 2010 07:32:26 +0000 (UTC)
	(envelope-from rrs@lakerest.net)
Received: from lakerest.net (unknown [IPv6:2001:240:585:2:213:d4ff:fef3:2d8d])
	by mx1.freebsd.org (Postfix) with ESMTP id D99FE8FC14
	for <freebsd-mips@freebsd.org>; Wed, 26 May 2010 07:32:25 +0000 (UTC)
Received: from [10.1.1.53] ([10.1.1.53]) (authenticated bits=0)
	by lakerest.net (8.14.3/8.14.3) with ESMTP id o4Q7WOkm018695
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT);
	Wed, 26 May 2010 03:32:25 -0400 (EDT)
	(envelope-from rrs@lakerest.net)
DKIM-Signature: a=rsa-sha1; c=simple/simple; d=lakerest.net; s=mail;
	t=1274859145; h=Cc:Message-Id:From:To:In-Reply-To:Content-Type:
	Content-Transfer-Encoding:Mime-Version:Subject:Date:References:
	X-Mailer; b=DbpfgC7UR23oQWhE2r20PR4Ir7P72Aj9d63Vp4v49AE94p/d9MXl0A6
	rUHNmBly7im/cwYRC/IDarwOzv7xK1Q==
Message-Id: <35D2DD59-83B6-4D7A-9619-E29424ABEDF1@lakerest.net>
From: Randall Stewart <rrs@lakerest.net>
To: Neel Natu <neelnatu@gmail.com>
In-Reply-To: <AANLkTim-be1YNot7fTSC8leHPuNp5003ku-78rbAI4at@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Date: Wed, 26 May 2010 03:32:24 -0400
References: <AANLkTiluuD6YtgYBRj25FixyzGyrGNwQZmvB_nOeCFWN@mail.gmail.com>
	<AANLkTim-be1YNot7fTSC8leHPuNp5003ku-78rbAI4at@mail.gmail.com>
X-Mailer: Apple Mail (2.936)
Cc: freebsd-mips@freebsd.org
Subject: Re: Fixes to the new pagetable page allocation code.
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 May 2010 07:32:26 -0000

JC:

It looks good to me too ;-)

R
On May 26, 2010, at 1:30 AM, Neel Natu wrote:

> Hi JC,
>
> On Tue, May 25, 2010 at 10:03 PM, C. Jayachandran
> <c.jayachandran@gmail.com> wrote:
>> The attached patch (also at
>> http://people.freebsd.org/~jchandra/for-review/pmap-alloc-page-fix.diff)
>> has two fixes for the new pagetable page allocation code, one to
>> handle NULL return from the allocating function, and another to call
>> VM_WAIT in cases we can wait. It also removes the variable 'req' left
>> over from an earlier change.
>>
>> Please let me know if you have any comments...
>>
>
> Your patch looks fine.
>
> Checking the value of 'ptdpg' is redundant given that you are passing
> in M_WAITOK. I don't think we expect the allocation to fail now that
> you have added the check for M_WAITOK in zone allocator function.
>
> best
> Neel
>
>> JC.
>>
>

------------------------------
Randall Stewart
803-317-4952 (cell)