From owner-freebsd-current@FreeBSD.ORG Mon Apr 12 23:16:55 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC07E16A4CE; Mon, 12 Apr 2004 23:16:55 -0700 (PDT) Received: from shuttle.wide.toshiba.co.jp (shuttle.wide.toshiba.co.jp [202.249.10.124]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8C9CB43D48; Mon, 12 Apr 2004 23:16:55 -0700 (PDT) (envelope-from jinmei@isl.rdc.toshiba.co.jp) Received: from ocean.jinmei.org (unknown [2001:200:0:8002:200:39ff:fe5e:cfd7]) by shuttle.wide.toshiba.co.jp (Postfix) with ESMTP id ADCB015210; Tue, 13 Apr 2004 15:16:54 +0900 (JST) Date: Tue, 13 Apr 2004 15:16:55 +0900 Message-ID: From: JINMEI Tatuya / =?ISO-2022-JP?B?GyRCP0BMQEMjOkgbKEI=?= To: Luigi Rizzo In-Reply-To: <20040412075638.B67293@xorpc.icir.org> References: <20040409042720.A99087@xorpc.icir.org> User-Agent: Wanderlust/2.10.1 (Watching The Wheels) Emacs/21.3 Mule/5.0 (SAKAKI) Organization: Research & Development Center, Toshiba Corp., Kawasaki, Japan. MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII X-Mailman-Approved-At: Tue, 13 Apr 2004 04:50:20 -0700 cc: ume@freebsd.org cc: core@kame.net cc: andre@freebsd.org cc: current@freebsd.org cc: net@freebsd.org Subject: Re: suggested patches for netinet6/ X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2004 06:16:55 -0000 >>>>> On Mon, 12 Apr 2004 07:56:38 -0700, >>>>> Luigi Rizzo said: >> > + is it ok to remove the __P() from the header files, ANSIfy >> > the function declarations and make them static as appropriate ? >> > Of course this ought to be done as a separate step. >> >> I myself do not have a strong opinion on this. However, these files >> would also be shared with other BSDs via KAME snaps, and if this >> change is not accepted by other BSDs, I'd like to keep it for future >> synchronization between KAME and BSDs. > ok, I am just unclear if we periodically import KAME sources in the > tree and then reapply freebsd changes (trying to keep the latter > as small as possible) or someone from time to time looks at > relevant changes in the KAME tree and patches the freebsd version > accordingly. In the latter case, ANSIfying the code would have little > impact on the people porting back the patches, yet would help a lot > in using stricter compiler checks. Out of curiosity (as a novice compiler user), could you be more specific on how it helps with stricter compiler checks to remove __P()? For example, what kind of checks does interfere with __P()? JINMEI, Tatuya Communication Platform Lab. Corporate R&D Center, Toshiba Corp. jinmei@isl.rdc.toshiba.co.jp