From owner-freebsd-fs@FreeBSD.ORG Wed Jun 29 11:04:17 2011 Return-Path: Delivered-To: fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A025E1065670 for ; Wed, 29 Jun 2011 11:04:17 +0000 (UTC) (envelope-from gjb@FreeBSD.org) Received: from glenbarber.us (onyx.glenbarber.us [199.48.134.227]) by mx1.freebsd.org (Postfix) with SMTP id 664088FC14 for ; Wed, 29 Jun 2011 11:04:17 +0000 (UTC) Received: (qmail 41174 invoked by uid 0); 29 Jun 2011 06:37:34 -0400 Received: from unknown (HELO schism.local) (gjb@76.124.49.145) by 0 with SMTP; 29 Jun 2011 06:37:34 -0400 Message-ID: <4E0B006C.8050000@FreeBSD.org> Date: Wed, 29 Jun 2011 06:37:32 -0400 From: Glen Barber User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: Alexander Leidinger References: <20110628203228.GA4957@onyx.glenbarber.us> <20110629104633.26824evikzh8tgtl@webmail.leidinger.net> In-Reply-To: <20110629104633.26824evikzh8tgtl@webmail.leidinger.net> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: fs@FreeBSD.org Subject: Re: [RFC] [patch] periodic status-zfs: list pools in daily emails X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2011 11:04:17 -0000 Hi Alexander, On 6/29/11 4:46 AM, Alexander Leidinger wrote: >> I added a default behavior to list the pools on the system, in >> addition to >> checking if the pool is healthy. I think it might be useful for >> others to >> have this as the default behavior, for example on systems where dedup is >> enabled to track the dedup statistics over time. > > I do not think this is a bad idea to be able to see the pools... but > IMHO it should be configurable (no strong opinion about "enabled or > disabled by default"). > Agreed. I can add this in. >> The output of the the script after my changes follows: > > Info to others: this is the default output, there is no special option > to track DEDUP. > >> Checking status of zfs pools: >> NAME SIZE ALLOC FREE CAP DEDUP HEALTH ALTROOT >> zroot 456G 147G 309G 32% 1.00x ONLINE - >> zstore 928G 258G 670G 27% 1.00x ONLINE - >> all pools are healthy >> >> Feedback would be appreciated. A diff is attached. > > Did you test it with an unhealthy pool? If yes, how does the result look > like? > I have not, yet. I can do this later today by breaking a mirror. > For the healthy case we have redundant info (but as the brain is good at > pattern matching, I would object to replace the status with the list > output, in case someone would suggest this). In the unhealthy case we > will surely have more info, my inquiry about it is if an empty line > between the list and the status would make it more readable or not. > I will reply later today with of the script with an unhealthy pool, and will make listing the pools configurable. I imagine an empty line would certainly make it more readable in either case. I would be reluctant to replace 'status' output with 'list' output for healthy pools mostly to avoid headaches for people parsing their daily email, specifically looking for (or missing) 'all pools are healthy.' Regards, -- Glen Barber | gjb@FreeBSD.org FreeBSD Documentation Project