From owner-freebsd-current@FreeBSD.ORG Sun Nov 20 20:24:02 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E2EA106566B; Sun, 20 Nov 2011 20:24:02 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 696828FC0C; Sun, 20 Nov 2011 20:24:01 +0000 (UTC) Received: by wwg14 with SMTP id 14so8530220wwg.31 for ; Sun, 20 Nov 2011 12:24:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=2DP0Mjdt2At4tOfLAC3ncHgIMQPNs84zxw8Nhr3tPhY=; b=e0QeldnETzio7zRaPSdcXxhJHDmyk6Hs6Y6mCD4Ie5glLwYhl5ZXEkCFpUOu70kuAN 832L1VGsYCl0ognIER8zkHHNhldV3z7Aac87ds69Rer66WR1/GoiAnpUEZQkWKPU6ws9 p21FtJnIVfD3y0CiymZ/vnj0qZ57e4uthfkqo= MIME-Version: 1.0 Received: by 10.180.109.106 with SMTP id hr10mr14500983wib.9.1321820639259; Sun, 20 Nov 2011 12:23:59 -0800 (PST) Sender: asmrookie@gmail.com Received: by 10.216.85.8 with HTTP; Sun, 20 Nov 2011 12:23:59 -0800 (PST) In-Reply-To: <20111120202141.GC50300@deviant.kiev.zoral.com.ua> References: <20111116084542.GY50300@deviant.kiev.zoral.com.ua> <20111118105224.GB50300@deviant.kiev.zoral.com.ua> <20111120191835.GB50300@deviant.kiev.zoral.com.ua> <20111120202141.GC50300@deviant.kiev.zoral.com.ua> Date: Sun, 20 Nov 2011 21:23:59 +0100 X-Google-Sender-Auth: tpXmWLdQLHHfQu3OdqxZiuCWkYM Message-ID: From: Attilio Rao To: Kostik Belousov Content-Type: text/plain; charset=UTF-8 Cc: mdf@freebsd.org, "K. Macy" , Alan Cox , Andriy Gapon , freebsd-current@freebsd.org, Benjamin Kaduk , Penta Upa Subject: Re: vm_page_t related KBI [Was: Re: panic at vm_page_wire with FreeBSD 9.0 Beta 3] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Nov 2011 20:24:02 -0000 2011/11/20 Kostik Belousov : > On Sun, Nov 20, 2011 at 08:22:38PM +0100, Attilio Rao wrote: >> 2011/11/20 Kostik Belousov : >> > On Sun, Nov 20, 2011 at 08:04:21PM +0100, Attilio Rao wrote: >> >> This other patch converts sx to a similar interface which cleans up vm_map.c: >> >> http://www.freebsd.org/~attilio/sxfileline.patch >> >> >> >> What do you think about it? >> > >> > This one only changes the KBI ? Note that _sx suffix is not reserved. >> >> In which sense? >> If you want to keep the shim support for KLD (thus the hard path) you >> will always need to keep an hard function and thus you still need a >> macro acting as a gate between the 'hard function' (or KLD version, if >> you prefer) and the fast case, that is where the "_" suffix came from. > > As I see, right now kernel exports e.g. _sx_try_slock() for the hard path. > After the patch, it will export sx_try_slock_() for the same purpose. > The old modules, which call _sx_try_slock(), cannot be loaded into > the patched kernel. Am I reading the patch wrong ? We shouldn't be concerned about it for -CURRENT, when MFCing this patch I'll just make: #define sx_try_slock_ _sx_try_slock rather than renaming the function. Attilio -- Peace can only be achieved by understanding - A. Einstein