From owner-p4-projects  Fri May 31 11: 1:32 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0E3D837B40A; Fri, 31 May 2002 11:00:54 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from rwcrmhc53.attbi.com (rwcrmhc53.attbi.com [204.127.198.39])
	by hub.freebsd.org (Postfix) with ESMTP
	id 0960137B411; Fri, 31 May 2002 11:00:27 -0700 (PDT)
Received: from InterJet.elischer.org ([12.232.206.8])
          by rwcrmhc53.attbi.com
          (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP
          id <20020531180026.PKGC11659.rwcrmhc53.attbi.com@InterJet.elischer.org>;
          Fri, 31 May 2002 18:00:26 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id KAA29135;
	Fri, 31 May 2002 10:54:14 -0700 (PDT)
Date: Fri, 31 May 2002 10:54:14 -0700 (PDT)
From: Julian Elischer <julian@elischer.org>
To: ticso@cicely.de
Cc: Julian Elischer <julian@FreeBSD.ORG>,
	Perforce Change Reviews <perforce@FreeBSD.ORG>
Subject: Re: PERFORCE change 12204 for review
In-Reply-To: <20020531174748.GA16281@cicely5.cicely.de>
Message-ID: <Pine.BSF.4.21.0205311052520.28852-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

no that cast is to unsigned int as that is what suword() takes
as an argument..

I would rather have a sptr() and fptr() set that is guaranteed to be
correct. 

comments from others?


On Fri, 31 May 2002, Bernd Walter wrote:

> On Fri, May 31, 2002 at 10:23:22AM -0700, Julian Elischer wrote:
> > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=12204
> > 
> > Change 12204 by julian@julian_ref on 2002/05/31 10:22:47
> > 
> > 	Change type of a pointer variable
> > 
> > Affected files ...
> > 
> > ... //depot/projects/kse/sys/kern/kern_thread.c#52 edit
> > 
> > Differences ...
> > 
> > ==== //depot/projects/kse/sys/kern/kern_thread.c#52 (text+ko) ====
> > 
> > @@ -251,7 +251,7 @@
> >  thread_export_context(struct thread *td)
> >  {
> >  	struct kse *ke;
> > -	uint td2_mbx; /* XXXKSE */
> > +	uintptr_t td2_mbx;
> >  	void *addr1;
> >  	void *addr2;
> >  	int error;
> 
> Don't forget the (uint) cast later in the same function.
> 
> -- 
> B.Walter              COSMO-Project         http://www.cosmo-project.de
> ticso@cicely.de         Usergroup           info@cosmo-project.de
> 
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message