From owner-svn-src-stable-10@FreeBSD.ORG Mon Mar 23 14:43:40 2015 Return-Path: Delivered-To: svn-src-stable-10@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 784E0757; Mon, 23 Mar 2015 14:43:40 +0000 (UTC) Received: from mail-la0-x230.google.com (mail-la0-x230.google.com [IPv6:2a00:1450:4010:c03::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0E93C7FC; Mon, 23 Mar 2015 14:43:40 +0000 (UTC) Received: by labto5 with SMTP id to5so28179112lab.0; Mon, 23 Mar 2015 07:43:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=FasvwP8lI+lsnVI3l7dTDgZiE4AFADmnlAnkL0QaZoM=; b=oojzq/HJD+94170K4v7Nj18RLNkAccqJ0kHQy9SSsZngkqkD1AMVoRaSZSZfg8hDXe ksj1JXlN86PfqtTTzyiuh8d+9BfLWniz8z+lJoVX5wP9xcgBO88Gn3JR7KhEosEHRalX fLhpGLSlDX6DpJWzmJDJk9zBmYz+YnLyfnUo5TOEqUwIkOV96dWZPrRTEMmfytpkaJ0/ s2o1Uvd1yDnf8KoVCgvLFRfp6zMLy3PMvp+2la5VCFYWMUOLtlXR0lwgz+D9C/WJow3w 9U6ZbreBLmerLBcnM/W3oIBFpWOKoZcC+BpxqTi2IzaDoD6HulM7tyG5vW4/IBoX2Afr ngmg== X-Received: by 10.152.37.228 with SMTP id b4mr55793471lak.111.1427121818121; Mon, 23 Mar 2015 07:43:38 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([134.249.139.101]) by mx.google.com with ESMTPSA id p2sm222560laj.29.2015.03.23.07.43.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Mar 2015 07:43:37 -0700 (PDT) Sender: Alexander Motin Message-ID: <55102697.8030903@FreeBSD.org> Date: Mon, 23 Mar 2015 16:43:35 +0200 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Dan Mack Subject: Re: svn commit: r280363 - stable/10/usr.sbin/bhyve References: <201503231148.t2NBmQ7o024956@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-10@freebsd.org X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Mar 2015 14:43:40 -0000 On 23.03.2015 16:35, Dan Mack wrote: > I just tried to build 280369 and got this: > > --- all_subdir_bhyve --- > /usr/src/usr.sbin/bhyve/pci_ahci.c:1512:8: error: use of undeclared > identifier 'dsm' > ncq = dsm = 0; > ^ > 1 error generated. > *** [pci_ahci.o] Error code 1 > > This is on 10.1-Stable Yes, it was my fault. Should be fixed by r280370. Sorry. > On Mon, 23 Mar 2015, Alexander Motin wrote: > >> Author: mav >> Date: Mon Mar 23 11:48:25 2015 >> New Revision: 280363 >> URL: https://svnweb.freebsd.org/changeset/base/280363 >> >> Log: >> MFC r280293: Add missing variable initialization. >> >> Reported by: Coverity >> CID: 1288938 >> >> Modified: >> stable/10/usr.sbin/bhyve/pci_ahci.c >> Directory Properties: >> stable/10/ (props changed) >> >> Modified: stable/10/usr.sbin/bhyve/pci_ahci.c >> ============================================================================== >> >> --- stable/10/usr.sbin/bhyve/pci_ahci.c Mon Mar 23 11:47:01 2015 >> (r280362) >> +++ stable/10/usr.sbin/bhyve/pci_ahci.c Mon Mar 23 11:48:25 2015 >> (r280363) >> @@ -1509,7 +1509,7 @@ ata_ioreq_cb(struct blockif_req *br, int >> >> DPRINTF("%s %d\n", __func__, err); >> >> - ncq = 0; >> + ncq = dsm = 0; >> aior = br->br_param; >> p = aior->io_pr; >> cfis = aior->cfis; >> _______________________________________________ >> svn-src-all@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/svn-src-all >> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org" >> > > > dan > -- > Dan Mack > -- Alexander Motin