From owner-svn-src-all@FreeBSD.ORG  Fri Sep 18 16:47:55 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 80D0D106568D
	for <svn-src-all@freebsd.org>; Fri, 18 Sep 2009 16:47:55 +0000 (UTC)
	(envelope-from julian@elischer.org)
Received: from outJ.internet-mail-service.net (outj.internet-mail-service.net
	[216.240.47.233])
	by mx1.freebsd.org (Postfix) with ESMTP id 219098FC27
	for <svn-src-all@freebsd.org>; Fri, 18 Sep 2009 16:47:54 +0000 (UTC)
Received: from idiom.com (mx0.idiom.com [216.240.32.160])
	by out.internet-mail-service.net (Postfix) with ESMTP id B10E7C482;
	Fri, 18 Sep 2009 09:47:54 -0700 (PDT)
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
X-Client-Authorized: MaGic Cook1e
Received: from julian-mac.elischer.org (home.elischer.org [216.240.48.38])
	by idiom.com (Postfix) with ESMTP id B4C7B2D601F;
	Fri, 18 Sep 2009 09:47:52 -0700 (PDT)
Message-ID: <4AB3B9B8.4060600@elischer.org>
Date: Fri, 18 Sep 2009 09:47:52 -0700
From: Julian Elischer <julian@elischer.org>
User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812)
MIME-Version: 1.0
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
References: <200909171452.n8HEqFfs061011@svn.freebsd.org>
	<20090917151723.GB2197@garage.freebsd.pl>
	<20090918005831.B68375@maildrop.int.zabbadoz.net>
	<20090918121233.GB3650@garage.freebsd.pl>
In-Reply-To: <20090918121233.GB3650@garage.freebsd.pl>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	"Bjoern A. Zeeb" <bz@FreeBSD.org>, Marko Zec <zec@FreeBSD.org>,
	src-committers@freebsd.org
Subject: Re: svn commit: r197286 - head/sys/net
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Sep 2009 16:47:55 -0000

Pawel Jakub Dawidek wrote:
> On Fri, Sep 18, 2009 at 12:59:49AM +0000, Bjoern A. Zeeb wrote:
>> On Thu, 17 Sep 2009, Pawel Jakub Dawidek wrote:
>>
>>> On Thu, Sep 17, 2009 at 02:52:15PM +0000, Marko Zec wrote:
>>>> Author: zec
>>>> Date: Thu Sep 17 14:52:15 2009
>>>> New Revision: 197286
>>>> URL: http://svn.freebsd.org/changeset/base/197286
>>>>
>>>> Log:
>>>>  V_irtualize the lltables list, making ARP and ND reasonably
>>>>  usable again with options VIMAGE kernels.
>>>>
>>>>  Submitted by:	bz (the original version, probably identical to this 
>>>>  one)
>> Uncommitted for the reason to not interfere with bugfixing for 8.0-R.
>>
>>>>  Reviewed by:	many @ DevSummit Cambridge
>>>>  MFC after:	3 days
>>> [...]
>>>> +static void
>>>> +vnet_lltable_init()
>>>> +{
>>>> +
>>>> +	SLIST_INIT(&V_lltables);
>>>> +}
>>>> +VNET_SYSINIT(vnet_lltable_init, SI_SUB_PSEUDO, SI_ORDER_FIRST, 
>>>> vnet_lltable_init, NULL);
>> ANy I didn'thave this style bug;)
>>
>>> There is nothing we want to do when vnet is going away?
>> No things will clear itself up via other ways as the interfaces will
>> go away the table will empty itself, etc
> 
> So I guess it won't hurt to assert on uninit that the list is really
> empty?:)
> 


not a bad idea..  is there already an UNINIT? it may be the only user.