From owner-svn-src-all@FreeBSD.ORG Wed Sep 15 08:02:13 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D66A01065672; Wed, 15 Sep 2010 08:02:13 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 711618FC1D; Wed, 15 Sep 2010 08:02:12 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o8F829cd004173 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 15 Sep 2010 11:02:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o8F829wG046134; Wed, 15 Sep 2010 11:02:09 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o8F828xU046133; Wed, 15 Sep 2010 11:02:08 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 15 Sep 2010 11:02:08 +0300 From: Kostik Belousov To: David Xu Message-ID: <20100915080208.GG2465@deviant.kiev.zoral.com.ua> References: <201009150256.o8F2uXwX004579@svn.freebsd.org> <20100914231728.33ca7466@kan.dnsalias.net> <4C90ABD8.1020609@freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="VRy2DAmnTueP9XfJ" Content-Disposition: inline In-Reply-To: <4C90ABD8.1020609@freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Alexander Kabaev Subject: Re: svn commit: r212630 - in head/lib/libthr: . thread X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2010 08:02:14 -0000 --VRy2DAmnTueP9XfJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Sep 15, 2010 at 11:19:52AM +0000, David Xu wrote: > Alexander Kabaev wrote: > >On Wed, 15 Sep 2010 02:56:33 +0000 (UTC) > >David Xu wrote: > > > >>Author: davidxu > >>Date: Wed Sep 15 02:56:32 2010 > >>New Revision: 212630 > >>URL: http://svn.freebsd.org/changeset/base/212630 > >> > >>Log: > >> add code to support stack unwinding when thread exits. note that > >>only defer-mode cancellation works, asynchrnous mode does not work > >>because it lacks of libuwind's support. stack unwinding is not > >>enabled unless LIBTHR_UNWIND_STACK is defined in Makefile. > >> > >>Modified: > >> head/lib/libthr/Makefile > >> head/lib/libthr/thread/thr_clean.c > >> head/lib/libthr/thread/thr_create.c > >> head/lib/libthr/thread/thr_exit.c > >> head/lib/libthr/thread/thr_init.c > >> head/lib/libthr/thread/thr_private.h > >> > >>Modified: head/lib/libthr/Makefile > >>=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >>--- head/lib/libthr/Makefile Wed Sep 15 01:21:30 2010 > >>(r212629) +++ head/lib/libthr/Makefile Wed Sep 15 02:56:32 > >>2010 (r212630) @@ -25,6 +25,14 @@ > >>CFLAGS+=3D-I${.CURDIR}/../../libexec/rtld- > >>CFLAGS+=3D-I${.CURDIR}/../../libexec/rtld-elf/${MACHINE_CPUARCH} > >>CFLAGS+=3D-I${.CURDIR}/../libthread_db CFLAGS+=3D-Winline > >>+ > >>+LIBTHR_UNWIND_STACK=3Dyes > >>+ > >>+.ifdef LIBTHR_UNWIND_STACK > >>+CFLAGS+=3D-I${.CURDIR}/../../contrib/gcc -fexceptions=20 > >>+CFLAGS+=3D-D_PTHREAD_FORCED_UNWIND > >>+.endif > >>+ > >> > > > >Reaching into bowels of GCC like that is never good. > Any solution ? ;-) >=20 I think the used interfaces are part of the C++ ABI. As such, we can expect them to be present from the runtime support, and provide our own declarations in freebsd-implemented headers. --VRy2DAmnTueP9XfJ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkyQfYAACgkQC3+MBN1Mb4jDzgCg8Q5xwHd6YJvZCssE1r5m3jX8 qzcAoK8B+Xdj/ApOpIFxdXqzKT4i3/BI =CmJ5 -----END PGP SIGNATURE----- --VRy2DAmnTueP9XfJ--