From owner-freebsd-current@FreeBSD.ORG Fri Dec 4 16:37:56 2009 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from [127.0.0.1] (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by hub.freebsd.org (Postfix) with ESMTP id 53D721065672; Fri, 4 Dec 2009 16:37:56 +0000 (UTC) (envelope-from jkim@FreeBSD.org) From: Jung-uk Kim To: freebsd-current@FreeBSD.org Date: Fri, 4 Dec 2009 11:37:31 -0500 User-Agent: KMail/1.6.2 References: <9ab7eeeb0912021757g5f60a7edw3256e60e745c0c35@mail.gmail.com> <87tyw8o5xk.fsf@kobe.laptop> <9ab7eeeb0912031827vd32544fk996a65e871322091@mail.gmail.com> In-Reply-To: <9ab7eeeb0912031827vd32544fk996a65e871322091@mail.gmail.com> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Message-Id: <200912041137.42917.jkim@FreeBSD.org> Cc: freebsd-stable@freebsd.org, Giorgos Keramidas , Leonardo Santagostini Subject: Re: Could you please fix this ? X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Dec 2009 16:37:57 -0000 On Thursday 03 December 2009 09:27 pm, Leonardo Santagostini wrote: > Sorry, but ive not backed up this file, instead of this, i will > copy the entire function (in fact its very short) > > cpi_pcib_pci_attach(device_t dev) > { > struct acpi_pcib_softc *sc; > ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); > > if (device_get_unit(dev)==2){ > pci_write_config(dev, PCIR_COMMAND, PCIM_CMD_MEMEN | > PCIM_CMD_PORTEN, 1); > pci_enable_busmaster(dev); > pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, 1); > pci_write_config(dev, PCIR_MEMBASE_1, 0xf020, 2); > pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf020, 2); > pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1, 2); > } > if (device_get_unit(dev)==3){ > pci_write_config(dev, PCIR_COMMAND, PCIM_CMD_MEMEN | > PCIM_CMD_PORTEN, 1); > pci_enable_busmaster(dev); > pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, 1); > pci_write_config(dev, PCIR_MEMBASE_1, 0xf030, 2); > pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf030, 2); > pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1, 2); > } > > pcib_attach_common(dev); > sc = device_get_softc(dev); > sc->ap_handle = acpi_get_handle(dev); > return (acpi_pcib_attach(dev, &sc->ap_prt, > sc->ap_pcibsc.secbus)); } As mav@ pointed out yesterday, this hack is very specific to this hardware. As jhb@ pointed out some time ago, this problem will be properly addressed by his "multipass" device probing mechanism. Sorry, there's nothing we can commit ATM. Jung-uk Kim > Kind Regards > Leonardo Santagostini > > 2009/12/3 Giorgos Keramidas : > > On Thu, 3 Dec 2009 01:57:50 +0000, Leonardo Santagostini wrote: > >> Hello everybody, > >> > >> I was facing one big problem, i have a notebook, which is an > >> Acer Aspire 5920.  If you like i can send to you my messages > >> file. > >> > >> Which is: > >> > >> Intel(R) Core(TM)2 Duo CPU     T5550  @ 1.83GHz (1833.48-MHz > >> 686-class CPU) Intel(R) PRO/Wireless 3945ABG > >> Broadcom NetLink Gigabit Ethernet Controller > >> 2 Gigs RAM > >> 160 Gigs SATA > >> > >> The point was: > >> With ACPI disabled, i managed to boot but without WIFI; and with > >> ACPI enabled, the boot process hanged up all times. > >> > >> I fixed this adding > >> > >>     if (device_get_unit(dev)==2){ > >>         pci_write_config(dev, PCIR_COMMAND, PCIM_CMD_MEMEN | > >> PCIM_CMD_PORTEN, 1); pci_enable_busmaster(dev); > >>         pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, 1); > >>         pci_write_config(dev, PCIR_MEMBASE_1, 0xf020, 2); > >>         pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf020, 2); > >>         pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1, 2); > >>     } > >>     if (device_get_unit(dev)==3){ > >>         pci_write_config(dev, PCIR_COMMAND, PCIM_CMD_MEMEN | > >> PCIM_CMD_PORTEN, 1); pci_enable_busmaster(dev); > >>         pci_write_config(dev, PCIR_IOBASEL_1, 0xf0, 1); > >>         pci_write_config(dev, PCIR_MEMBASE_1, 0xf030, 2); > >>         pci_write_config(dev, PCIR_MEMLIMIT_1, 0xf030, 2); > >>         pci_write_config(dev, PCIR_PMBASEL_1, 0xfff1, 2); > >>     } > >> > >> to /usr/src/sys/dev/acpica/acpi_pcib_pci.c running on a > >> 8.0-RELEASE > >> > >> I was able to fix it by my way but many people cant do it, so, i > >> would really appreciate if you can add this piece of code. > > > > Hi Leonardo. > > > > Jung-uk Kim has done a lot of ACPI-related work, so he will > > probably know if the change is ok to commit to stable/8.  I've > > added him to the thread, so he can let us know what he thinks of > > the change.  Can you please post a diff that also shows _where_ > > the changes have to be installed in our current version of > > src/sys/dev/acpica/acpi_pcib_pci.c for 8.0-RELEASE?