From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Dec 29 20:50:11 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E1A7D1065675 for ; Wed, 29 Dec 2010 20:50:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id BE1DE8FC1C for ; Wed, 29 Dec 2010 20:50:11 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oBTKoBFq094419 for ; Wed, 29 Dec 2010 20:50:11 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oBTKoBgp094418; Wed, 29 Dec 2010 20:50:11 GMT (envelope-from gnats) Resent-Date: Wed, 29 Dec 2010 20:50:11 GMT Resent-Message-Id: <201012292050.oBTKoBgp094418@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Charlie Kester Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8B510106564A for ; Wed, 29 Dec 2010 20:48:43 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 5FDFE8FC18 for ; Wed, 29 Dec 2010 20:48:43 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id oBTKmhQD004851 for ; Wed, 29 Dec 2010 20:48:43 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id oBTKmhCx004850; Wed, 29 Dec 2010 20:48:43 GMT (envelope-from nobody) Message-Id: <201012292048.oBTKmhCx004850@red.freebsd.org> Date: Wed, 29 Dec 2010 20:48:43 GMT From: Charlie Kester To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/153532: [PATCH] devel/dbus: fix build failure in the presence of textproc/man2html X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Dec 2010 20:50:12 -0000 >Number: 153532 >Category: ports >Synopsis: [PATCH] devel/dbus: fix build failure in the presence of textproc/man2html >Confidential: no >Severity: serious >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Dec 29 20:50:11 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Charlie Kester >Release: FreeBSD 8.2-PRERELEASE #0: Wed Dec 15 19:43:46 PST 2010 >Organization: >Environment: >Description: If /textproc/man2html is installed, the build of devel/dbus fails. Several people on the forums and questions@ mailinglist have reported this. The root cause of this failure is that the dbus Makefiles expect a version of man2html which will take a filename as input. But textproc/man2html only accepts input on stdin. It ignores any filenames specified on its commandline. So the build appears to hang when the following Makefile lines are executed: %.1.html: %.1 $(AM_V_GEN)( $(MAN2HTML) $< > $@.tmp && mv $@.tmp $@ ) Actually, it isn't hung. man2html is simply waiting for input on stdin. If man2html is not installed, the devel/dbus succeeds. I notice that the html'ized manpages are not listed in the pkg-plist for dbus, nor are they mentioned in the port's Makefile. Is it expected that they will never be installed, even though the upstream author's Makefile will build them if man2html is found? >How-To-Repeat: Install textproc/man2html Try to build devel/dbus >Fix: Redirect stdin to the prerequisite file Patch attached with submission follows: diff -ruN /usr/ports/devel/dbus/files/patch-doc__Makefile.in ./dbus/files/patch-doc__Makefile.in --- /usr/ports/devel/dbus/files/patch-doc__Makefile.in 1969-12-31 16:00:00.000000000 -0800 +++ ./dbus/files/patch-doc__Makefile.in 2010-12-29 12:22:16.000000000 -0800 @@ -0,0 +1,11 @@ +--- ./doc/Makefile.in.orig 2010-12-29 12:21:33.000000000 -0800 ++++ ./doc/Makefile.in 2010-12-29 12:21:52.000000000 -0800 +@@ -609,7 +609,7 @@ + @DBUS_HAVE_MAN2HTML_TRUE@all-local:: $(MAN_HTML_FILES) + + @DBUS_HAVE_MAN2HTML_TRUE@%.1.html: %.1 +-@DBUS_HAVE_MAN2HTML_TRUE@ $(AM_V_GEN)( $(MAN2HTML) $< > $@.tmp && mv $@.tmp $@ ) ++@DBUS_HAVE_MAN2HTML_TRUE@ $(AM_V_GEN)( $(MAN2HTML) < $< > $@.tmp && mv $@.tmp $@ ) + + @DBUS_CAN_UPLOAD_DOCS_TRUE@dbus-docs: $(STATIC_DOCS) $(HTML_FILES) $(MAN_HTML_FILES) $(BONUS_FILES) $(DOXYGEN_HTML_INDEX) + @DBUS_CAN_UPLOAD_DOCS_TRUE@ $(AM_V_at)rm -rf $@ >Release-Note: >Audit-Trail: >Unformatted: