From owner-svn-src-head@FreeBSD.ORG Wed Sep 15 16:14:54 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EB44E10657BE; Wed, 15 Sep 2010 16:14:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 42B588FC18; Wed, 15 Sep 2010 16:14:51 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id DCA7146C05; Wed, 15 Sep 2010 12:14:50 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 913EF8A04E; Wed, 15 Sep 2010 12:14:48 -0400 (EDT) From: John Baldwin To: Kostik Belousov Date: Wed, 15 Sep 2010 12:14:33 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201009151424.o8FEOLZE039185@svn.freebsd.org> <20100915145209.GK2465@deviant.kiev.zoral.com.ua> In-Reply-To: <20100915145209.GK2465@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201009151214.33375.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Wed, 15 Sep 2010 12:14:48 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Attilio Rao , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212661 - head/sys/dev/aac X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2010 16:14:54 -0000 On Wednesday, September 15, 2010 10:52:09 am Kostik Belousov wrote: > On Wed, Sep 15, 2010 at 02:24:21PM +0000, Attilio Rao wrote: > > Author: attilio > > Date: Wed Sep 15 14:24:21 2010 > > New Revision: 212661 > > URL: http://svn.freebsd.org/changeset/base/212661 > > > > Log: > > Fix bogus busying mechanism from cdevsw callbacks: > > - D_TRACKCLOSE may be used there as d_close() are expected to match up > > d_open() calls > VFS is not very good at properly calling VOP_CLOSE(). As example, premature > vnode reclaim due to devfs unmount would cause VOP_CLOSE() to be called > only once despite the number of opens being > 1. cdevpriv is probably a much better route for handling this than D_TRACKCLOSE. The destructor routine passed to devfs_set_cdevpriv() would just do the work of decrementing the reference count instead of actually freeing anything in that case. -- John Baldwin