From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 8 22:50:06 2006 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FA9116A420 for ; Wed, 8 Mar 2006 22:50:06 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id ACCA143D48 for ; Wed, 8 Mar 2006 22:50:05 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k28Mo5qG067864 for ; Wed, 8 Mar 2006 22:50:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k28Mo5Y8067863; Wed, 8 Mar 2006 22:50:05 GMT (envelope-from gnats) Resent-Date: Wed, 8 Mar 2006 22:50:05 GMT Resent-Message-Id: <200603082250.k28Mo5Y8067863@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Dave Thompson Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8175316A420 for ; Wed, 8 Mar 2006 22:47:32 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 502FD43D45 for ; Wed, 8 Mar 2006 22:47:32 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k28MlWPE044628 for ; Wed, 8 Mar 2006 22:47:32 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id k28MlW5e044627; Wed, 8 Mar 2006 22:47:32 GMT (envelope-from nobody) Message-Id: <200603082247.k28MlW5e044627@www.freebsd.org> Date: Wed, 8 Mar 2006 22:47:32 GMT From: Dave Thompson To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Cc: Subject: kern/94249: Inconsistent use of time_second & time_uptime in in_rmx.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Mar 2006 22:50:06 -0000 >Number: 94249 >Category: kern >Synopsis: Inconsistent use of time_second & time_uptime in in_rmx.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Mar 08 22:50:04 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Dave Thompson >Release: 7.0_CURRENT >Organization: Cisco Systems >Environment: FreeBSD stack 7.0-CURRENT FreeBSD 7.0-CURRENT #56: Wed Mar 8 21:13:43 CST 2006 davetho@davetho-freebsd.cisco.com:/local/davetho/cvs/csi/freebsd7_xen3/src/sys/i386-xen/compile/XENCONF i386 >Description: The function in_rtqtimo() of netinet/in_rmx.c uses time_second to set the starting value of arg.nextstop. When the rnh tree is walked, the nextstop arg can then be changed in in_rtqkill() to rt->rt_rmx.rmx_expire which is set using time_uptime. On my system (with the DIAGNOSTIC option turned on), this causes the tvtohz() call at the end of the in_rtqtimo() function to display a console message that the atv.tv_sec value is negative. This is negative because on my system the time_second value is a very large value and the time_uptime is a small value. >How-To-Repeat: Turn the DIAGNOSTIC option on and wait for the in_rtqtimo() function to run. >Fix: Change the references to time_second in in_rtqtimo() of netinet/in_rmx.c to use time_uptime instead. This will be consistent with the use of time_uptime in the other related functions. >Release-Note: >Audit-Trail: >Unformatted: