From owner-freebsd-bugs@FreeBSD.ORG Wed Sep 20 16:51:18 2006 Return-Path: X-Original-To: freebsd-bugs@freebsd.org Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2CFC416A407; Wed, 20 Sep 2006 16:51:18 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id 953D443D66; Wed, 20 Sep 2006 16:50:58 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id k8KGnnO9061765; Wed, 20 Sep 2006 10:49:49 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 20 Sep 2006 10:49:04 -0600 (MDT) Message-Id: <20060920.104904.-1350498260.imp@bsdimp.com> To: keiji@hiemalis.org From: "M. Warner Losh" In-Reply-To: <20060921.010358.39312857.keiji@hiemalis.org> References: <200508301807.j7UI70gH021119@www.freebsd.org> <200508301820.j7UIK0ee075010@freefall.freebsd.org> <20060921.010358.39312857.keiji@hiemalis.org> X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 20 Sep 2006 10:49:50 -0600 (MDT) Cc: freebsd-bugs@freebsd.org, FreeBSD-gnats-submit@freebsd.org Subject: Re: kern/85493: OLDCARD can't probe ed driver X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2006 16:51:18 -0000 In message: <20060921.010358.39312857.keiji@hiemalis.org> Wada Keiji writes: : Hello imp! : : Why don't you accept my change request? : : Did you read sys/dev/pccard/card_if.m : # Compatibility methods for OLDCARD drivers. We use these routines to make : # it possible to call the OLDCARD driver's probe routine in the context that : # it expects. For OLDCARD these are implemented as pass throughs to the : # device_{probe,attach} routines. For NEWCARD they are implemented such : # such that probe becomes strictly a matching routine and attach does both : # the old probe and old attach. : # : # compat devices should use the following: : # : # /* Device interface */ : # DEVMETHOD(device_probe), pccard_compat_probe), : # DEVMETHOD(device_attach), pccard_compat_attach), : # /* Card interface */ : # DEVMETHOD(card_compat_match, foo_match), /* newly written */ : # DEVMETHOD(card_compat_probe, foo_probe), /* old probe */ : # DEVMETHOD(card_compat_attach, foo_attach), /* old attach */ : : I think that card_compat_probe is used on OLDCARD. And on ed : ed_pccard_probe is used too. So ed_pccard_probe can't use : pccard_product_lookup function. : : What do you think? OLDCARD has been retro-fitted to allow the use of pccard_product_lookup. If that isn't working, the bug should be fixed there. It has been a long time since I have built and run an oldcard kernel. I kept meaning to get back to this bug, and appologize for my lack of action on it. The patch in this report might fix OLDCARD, but seem to break it for NEWCARD, which is why I never applied them. What is failing in the pccard_product_lookup function? Warner : Thanks. : : >>>>> On Tue, 30 Aug 2005 18:20:00 GMT : >>>>> FreeBSD-gnats-submit@FreeBSD.org said: : > : > Thank you very much for your problem report. : > It has the internal identification `kern/85493'. : > The individual assigned to look at your : > report is: freebsd-bugs. : > : > You can access the state of your problem report at any time : > via this link: : > : > http://www.freebsd.org/cgi/query-pr.cgi?pr=85493 : > : > >Category: kern : > >Responsible: freebsd-bugs : > >Synopsis: OLDCARD can't probe ed driver : > >Arrival-Date: Tue Aug 30 18:20:00 GMT 2005 : :