From owner-cvs-all@FreeBSD.ORG Fri Dec 2 16:02:15 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6CBB6106564A; Fri, 2 Dec 2011 16:02:15 +0000 (UTC) (envelope-from glarkin@FreeBSD.org) Received: from mail1.sourcehosting.net (mail1.sourcehosting.net [74.205.51.45]) by mx1.freebsd.org (Postfix) with ESMTP id 3B3838FC0A; Fri, 2 Dec 2011 16:02:15 +0000 (UTC) Received: from 68-189-245-235.dhcp.oxfr.ma.charter.com ([68.189.245.235] helo=imac.entropy.prv) by mail1.sourcehosting.net with esmtp (Exim 4.73 (FreeBSD)) (envelope-from ) id 1RWVYm-000GEo-6l; Fri, 02 Dec 2011 11:02:10 -0500 Received: from imac.entropy.prv (localhost [127.0.0.1]) by imac.entropy.prv (Postfix) with ESMTP id 17F42C2A4BA; Fri, 2 Dec 2011 11:02:03 -0500 (EST) Message-ID: <4ED8F67A.1040702@FreeBSD.org> Date: Fri, 02 Dec 2011 11:02:02 -0500 From: Greg Larkin Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.24) Gecko/20111103 Lightning/1.0b2 Thunderbird/3.1.16 MIME-Version: 1.0 To: Wesley Shields References: <201111292239.pATMdtGq022326@repoman.freebsd.org> <20111202140059.GG56180@atarininja.org> <20B7E8C1930569419B93027F125DAB1506D1E214@USBCTDC001> <20111202154352.GH56180@atarininja.org> In-Reply-To: <20111202154352.GH56180@atarininja.org> X-Enigmail-Version: 1.1.1 OpenPGP: id=1C940290 X-SA-Exim-Connect-IP: 68.189.245.235 X-SA-Exim-Mail-From: glarkin@FreeBSD.org X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail1.sourcehosting.net X-Spam-Level: ** X-Spam-Status: No, score=2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_PBL, RCVD_IN_RP_RNBL, RCVD_IN_SORBS_DUL, RDNS_DYNAMIC, TVD_RCVD_IP autolearn=no version=3.3.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SA-Exim-Version: 4.2 X-SA-Exim-Scanned: Yes (on mail1.sourcehosting.net) Cc: Michael Scheidell , "'cvs-ports@FreeBSD.org'" , "'cvs-all@FreeBSD.org'" , "'ports-committers@FreeBSD.org'" Subject: Re: cvs commit: ports/security/fprint_demo Makefile distinfo pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: glarkin@FreeBSD.org List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2011 16:02:15 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 12/2/11 10:43 AM, Wesley Shields wrote: > On Fri, Dec 02, 2011 at 02:16:32PM +0000, Michael Scheidell wrote: [...] > >>> | --- ports/security/fprint_demo/distinfo 2011/11/29 12:59:55 1.3 >>> | +++ ports/security/fprint_demo/distinfo 2011/11/29 22:39:55 1.4 >>> | @@ -1,2 +1,4 @@ >>> | -SHA256 (fprint-demo_20080303+git.orig.tar.gz) = >>> | fcff7f6e8d61b253b88dd87ecf5cdb5418ecf11178ce7cb6ae0e350485045232 >>> | -SIZE (fprint-demo_20080303+git.orig.tar.gz) = 77714 >>> | +SHA256 (fprint-demo_20080303git.orig.tar.gz) = >>> | +fcff7f6e8d61b253b88dd87ecf5cdb5418ecf11178ce7cb6ae0e350485045232 >>> | +SIZE (fprint-demo_20080303git.orig.tar.gz) = 77714 >>> | +#http://mirrors.arsc.edu/ubuntu/packages/pool/ >>> | +#universe/f/fprint-demo/fprint-demo_20080303git.orig.tar.gz >> >> Are these last two lines really meant to be there? >> >> Mostly to document that its in a STRANGE place (pam_fprint is in >> _20080203+git) > > Not where I would put it. I'd put this information in the Makefile along > with a comment explaining it. Again, no major harm and this is your port > but the norm is to keep this information in Makefile and leave distinfo > for recording size and checksums only. > > -- WXS Plus, the entire distinfo file will be rewritten from scratch the next time "make makesum" is run, and any comments will be lost. Regards, Greg - -- Greg Larkin http://www.FreeBSD.org/ - The Power To Serve http://www.sourcehosting.net/ - Ready. Set. Code. http://twitter.com/cpucycle/ - Follow you, follow me -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk7Y9noACgkQ0sRouByUApC8xACfUiIBa3Cg3og4cNVukE6vILWH Md8AoLDRJCa//hxk0LgypBTWgZku4BXd =qTGn -----END PGP SIGNATURE-----