From owner-cvs-src@FreeBSD.ORG  Sat Jan 21 14:04:10 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8E7A716A41F;
	Sat, 21 Jan 2006 14:04:10 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3BB4043D46;
	Sat, 21 Jan 2006 14:04:10 +0000 (GMT)
	(envelope-from rwatson@FreeBSD.org)
Received: from fledge.watson.org (fledge.watson.org [209.31.154.41])
	by cyrus.watson.org (Postfix) with ESMTP id 222C846C09;
	Sat, 21 Jan 2006 09:04:05 -0500 (EST)
Date: Sat, 21 Jan 2006 14:05:06 +0000 (GMT)
From: Robert Watson <rwatson@FreeBSD.org>
X-X-Sender: robert@fledge.watson.org
To: Stefan Farfeleder <stefanf@FreeBSD.org>
In-Reply-To: <20060121134636.GC611@wombat.fafoe.narf.at>
Message-ID: <20060121140330.S93517@fledge.watson.org>
References: <200601211210.k0LCAXYl069896@repoman.freebsd.org>
	<20060121134636.GC611@wombat.fafoe.narf.at>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: Tom Rhodes <trhodes@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-all@FreeBSD.org, cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/sys/nfsserver nfs_serv.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 21 Jan 2006 14:04:10 -0000


On Sat, 21 Jan 2006, Stefan Farfeleder wrote:

> On Sat, Jan 21, 2006 at 12:10:33PM +0000, Tom Rhodes wrote:
>> trhodes     2006-01-21 12:10:33 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/nfsserver        nfs_serv.c
>>   Log:
>>   Remove some dead code.
>>
>>   Found with:     Coverity Prevent(tm)
>
> Hm, are you sure this change is correct?  Apparently Coverity thinks that 
> dirp is always 0 at this point, yes?  Looking at nfs_namei() I don't believe 
> that.  Also the comment above this is now stale and the code inside 'if 
> (error)' not indented properly.

I was purposefully avoiding trying to investigate the NFS reports from 
Coverity as the NFS macro maze is very twisty, and the dead code reports are 
more likely logical errors preventing reaching code that shouldn't be dead 
than code that is actually no longer useful.  I figured I would leave them for 
a quiet long weekend.  Given the above, I suspect strongly my instinct was 
right. :-)

Robert N M Watson