From owner-freebsd-bugs@FreeBSD.ORG Thu Jun 28 23:30:09 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D915A16A468 for ; Thu, 28 Jun 2007 23:30:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id B9E3413C45D for ; Thu, 28 Jun 2007 23:30:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l5SNU95n035127 for ; Thu, 28 Jun 2007 23:30:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l5SNU9Tr035126; Thu, 28 Jun 2007 23:30:09 GMT (envelope-from gnats) Resent-Date: Thu, 28 Jun 2007 23:30:09 GMT Resent-Message-Id: <200706282330.l5SNU9Tr035126@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alan Grow Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 91F6B16A41F for ; Thu, 28 Jun 2007 23:28:55 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [69.147.83.33]) by mx1.freebsd.org (Postfix) with ESMTP id 8344913C45D for ; Thu, 28 Jun 2007 23:28:55 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l5SNStNH077112 for ; Thu, 28 Jun 2007 23:28:55 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id l5SNStXR077111; Thu, 28 Jun 2007 23:28:55 GMT (envelope-from nobody) Message-Id: <200706282328.l5SNStXR077111@www.freebsd.org> Date: Thu, 28 Jun 2007 23:28:55 GMT From: Alan Grow To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.0 Cc: Subject: kern/114113: ACPI kernel panic during S3 suspend / resume X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jun 2007 23:30:09 -0000 >Number: 114113 >Category: kern >Synopsis: ACPI kernel panic during S3 suspend / resume >Confidential: no >Severity: critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jun 28 23:30:09 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Alan Grow >Release: -CURRENT >Organization: >Environment: FreeBSD host 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Thu Jun 28 16:09:35 EDT 2007 root@host:/usr/obj/usr/src/sys/HOST i386 >Description: A -CURRENT build from yesterday panics every time on S3 suspend / resume: panic: _mtx_lock_sleep: recursed on non_recursive mutex acpi subsystem GPE lock @ ../../../dev/acpica/Osd/OsdSynch.c >How-To-Repeat: $ acpiconf -s 3 >Fix: The tip-off is in sys/contrib/dev/acpica/CHANGES.txt: "All interfaces to the global lock now allow the same thread to acquire the lock multiple times." However, mtx_init() is still called without the MTX_RECURSE flag in sys/dev/acpica/Osd/OsdSynch.c. The following patch fixes it for me: --- sys/dev/acpica/Osd/OsdSynch.c.orig 2007-06-28 18:35:07.000000000 -0400 +++ sys/dev/acpica/Osd/OsdSynch.c 2007-03-26 19:04:02.000000000 -0400 @@ -92,7 +92,7 @@ if ((as = malloc(sizeof(*as), M_ACPISEM, M_NOWAIT | M_ZERO)) == NULL) return_ACPI_STATUS (AE_NO_MEMORY); - mtx_init(&as->as_mtx, "ACPI semaphore", NULL, MTX_DEF | MTX_RECURSE); + mtx_init(&as->as_mtx, "ACPI semaphore", NULL, MTX_DEF); as->as_units = InitialUnits; as->as_maxunits = MaxUnits; as->as_pendings = as->as_resetting = as->as_timeouts = 0; @@ -346,7 +346,7 @@ snprintf(h->name, sizeof(h->name), "acpi subsystem HW lock"); else snprintf(h->name, sizeof(h->name), "acpi subsys %p", OutHandle); - mtx_init(&h->lock, h->name, NULL, MTX_DEF | MTX_RECURSE); + mtx_init(&h->lock, h->name, NULL, MTX_DEF); *OutHandle = (ACPI_SPINLOCK)h; return (AE_OK); } >Release-Note: >Audit-Trail: >Unformatted: