From owner-freebsd-current Sat Apr 27 10:13:38 2002 Delivered-To: freebsd-current@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 6E9F637B41F for ; Sat, 27 Apr 2002 10:13:32 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id DAA05648; Sun, 28 Apr 2002 03:13:28 +1000 Date: Sun, 28 Apr 2002 03:14:40 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: Shizuka Kudo Cc: freebsd-current@FreeBSD.ORG Subject: Re: Recent commit to sys/kern/kern_environment.c broke reading tunables In-Reply-To: <20020427034333.59636.qmail@web11408.mail.yahoo.com> Message-ID: <20020428030240.E735-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, 26 Apr 2002, Shizuka Kudo wrote: > It seems the latest commit of > sys/kern/kern_environment to current broke the reading > of system tunables set by loader.conf. This is true at > least for hw.cbb.start_mem of my cardbus bridge. With > this latest commit, the hw.cbb.start_mem sysctl still > shows the default value after boot up. > > Reverting back to version 1.22 solve my problem. Is > this unique to me? The tunable for this sysctl spelled inconsistently as "hw.cbb.start_memory", so rev.1.23 "fixed" finding it if it is misspelled in the environment as "hw.cbb.start_mem". From dev/pccbb/pccbb.c: /* There's no way to say TUNEABLE_LONG to get the right types */ u_long pccbb_start_mem = PCCBB_START_MEM; TUNABLE_INT("hw.cbb.start_memory", (int *)&pccbb_start_mem); SYSCTL_ULONG(_hw_cbb, OID_AUTO, start_mem, CTLFLAG_RD, &pccbb_start_mem, PCCBB_START_MEM, "Starting address for memory allocations"); Does changing the spelling in the environment to match the tunable fix the problem? Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message