From owner-cvs-all@FreeBSD.ORG Tue Aug 3 02:43:13 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 245BF16A4CE; Tue, 3 Aug 2004 02:43:13 +0000 (GMT) Received: from harmony.village.org (rover.village.org [168.103.84.182]) by mx1.FreeBSD.org (Postfix) with ESMTP id A8E0C43D1D; Tue, 3 Aug 2004 02:43:12 +0000 (GMT) (envelope-from imp@bsdimp.com) Received: from localhost (warner@rover2.village.org [10.0.0.1]) by harmony.village.org (8.12.11/8.12.11) with ESMTP id i732f64H002399; Mon, 2 Aug 2004 20:41:06 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Mon, 02 Aug 2004 20:41:35 -0600 (MDT) Message-Id: <20040802.204135.22958361.imp@bsdimp.com> To: njl@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <20040802.195537.104022299.imp@bsdimp.com> References: <200408030041.i730fl2S048673@repoman.freebsd.org> <20040802.195537.104022299.imp@bsdimp.com> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/eisa eisaconf.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Aug 2004 02:43:13 -0000 In message: <20040802.195537.104022299.imp@bsdimp.com> "M. Warner Losh" writes: : In message: <200408030041.i730fl2S048673@repoman.freebsd.org> : Nate Lawson writes: : : njl 2004-08-03 00:41:47 UTC : : : : FreeBSD src repository : : : : Modified files: : : sys/dev/eisa eisaconf.c : : Log: : : Change EISA probing to be less invasive. Instead of probing all slots : : unconditionally, stop after the first one (system board) if no EISA hardware : : is detected. This fixes a boot hang (i.e. Thinkpad) when ACPI is disabled. : : Also, split the probe code into a separate function and do some style cleanup. : : : : Note that the Adaptec 2842 VLB controller probe is broken by this change : : and will fail to probe. It should be fixed separately. : : This change, btw, was reviewed by gibbs and imp prior to the : commit... The 2842 VLB controller is about 13 years old. There will : likely be a fix for it soon from the ahc maintainer. However, even if : there isn't, the belief is that modern laptop owners with the eisa : hang problem is >> the 2842 controller. I believe the re@ signed off ^number of users with a : on this as well.