From owner-svn-src-all@FreeBSD.ORG Tue Feb 25 08:50:01 2014 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 24E47596; Tue, 25 Feb 2014 08:50:01 +0000 (UTC) Received: from theravensnest.org (theraven.freebsd.your.org [216.14.102.27]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E28EB1CE7; Tue, 25 Feb 2014 08:50:00 +0000 (UTC) Received: from [192.168.0.7] (cpc28-cmbg15-2-0-cust64.5-4.cable.virginm.net [86.27.189.65]) (authenticated bits=0) by theravensnest.org (8.14.7/8.14.5) with ESMTP id s1P8nrT2069813 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 25 Feb 2014 08:49:55 GMT (envelope-from theraven@FreeBSD.org) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: svn commit: r262282 - in head: contrib/dma contrib/dma/debian contrib/dma/debian/migrate contrib/dma/debian/source contrib/dma/test etc/mtree libexec libexec/dma share/mk tools/build/mk tools/build... From: David Chisnall In-Reply-To: <20140225075220.GF83610@ithaqua.etoilebsd.net> Date: Tue, 25 Feb 2014 08:49:47 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201402210726.s1L7QnBP007144@svn.freebsd.org> <20140222082350.GA2705@server.rulingia.com> <20140222121438.GO1699@ithaqua.etoilebsd.net> <20140225062222.GB2705@server.rulingia.com> <20140225075220.GF83610@ithaqua.etoilebsd.net> To: Baptiste Daroussin X-Mailer: Apple Mail (2.1827) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Peter Jeremy X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Feb 2014 08:50:01 -0000 On 25 Feb 2014, at 07:52, Baptiste Daroussin wrote: > On Tue, Feb 25, 2014 at 05:22:22PM +1100, Peter Jeremy wrote: >> On 2014-Feb-22 13:14:38 +0100, Baptiste Daroussin = wrote: >>> On Sat, Feb 22, 2014 at 07:23:50PM +1100, Peter Jeremy wrote: >>>> I'd also query the reason for including Debian-specific code in the >>>> FreeBSD base. >>=20 >>> Where have you seen debian specific code? >>=20 >> /usr/src/contrib/dma/debian - as far as I can tell, this directory is >> Debion specific. I thought we stripped out irrelevant code from = third >> party imports but looking wider, there is similarly irrelevant code = in >> a variety of other contrib imports. I'll withdraw that objection. >>=20 >> --=20 >> Peter Jeremy >=20 > Have you already looked at how contrib works? who cares FYI you can = also find > some win32 specific code in there, debian packaging code, rpm spec = files etc. For the libc++ imports, we strip out the support directory, which = contains Solaris and Win32-specific stuff. If we end up with a = support/freebsd, then we'll bring that in, but not support/solaris and = support/win32. That stuff is in the vendor branch, but it just seems = polite not to make people who check out head get files that are never = used when building FreeBSD in any configuration. David