From owner-svn-src-all@FreeBSD.ORG Mon Nov 11 19:20:09 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 9F719D02 for ; Mon, 11 Nov 2013 19:20:09 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-qc0-x22e.google.com (mail-qc0-x22e.google.com [IPv6:2607:f8b0:400d:c01::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 5B76C2F6F for ; Mon, 11 Nov 2013 19:20:09 +0000 (UTC) Received: by mail-qc0-f174.google.com with SMTP id v2so964068qcr.19 for ; Mon, 11 Nov 2013 11:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=8Adu/CtxJldfuUkhifRX/l1ue5u9qhN6IeayuI3VmnM=; b=iqPoqC9Ma0JVvlQ3u73cONth0eFGR0hhVkMv8STqrLXDdAIxmlLoDVMu5brXir0eTe w+fnZ4J0luCwGfvWSBUDAQhdUbNjMh2EjcFmFAkXBcouq7ESHB0CTmupHiut6DaoT3Cu msQu/kIPLoCVE+0HBSGLn2Ki3oEOtJ4PNMv7k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=8Adu/CtxJldfuUkhifRX/l1ue5u9qhN6IeayuI3VmnM=; b=lXhNxmKkdEh8yQPei5xC+SoT/rlvx1eKKgR4wFGypEFH9tnOBBjv8fXNwswIAF/uWn Wsk/yiFOYo2K1NeQ7KV+8HJ/rQeBDmZLsj7f5Hux3uUhmF3THd1Fj9WvaNQzaWrG4PZb 34jsO0YZET/YNNsGSQRs7FqUy4HJyO8+Jy4+LY0Sk6CJnYNg/nsd7bBFQZTSVX+U2yrx X8h5aOCIrNkmJKKumqSSBcYVogRvB2SuEzYyql1poMF7cYMabgU0I5E1BtxluWP788Ya a60HBrPce3d+A6xfXaofnpJZMdqefD6QSZtvS3gEd4wqHS8mO2tkelU7Xnj6702YBJQa CzoA== X-Gm-Message-State: ALoCoQlA/w/SL2n1OqVmOyRdo4KksMLRm+fK8oy/7K46hJ9r5yFXUPxQZaSUDEcPtzxCKbx4Dg9A X-Received: by 10.49.103.161 with SMTP id fx1mr50013756qeb.68.1384197608599; Mon, 11 Nov 2013 11:20:08 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.96.63.101 with HTTP; Mon, 11 Nov 2013 11:19:38 -0800 (PST) In-Reply-To: <20131111153544.GI98118@admin.xzibition.com> References: <201311110744.rAB7iA6g041490@svn.freebsd.org> <20131111153544.GI98118@admin.xzibition.com> From: Eitan Adler Date: Mon, 11 Nov 2013 14:19:38 -0500 X-Google-Sender-Auth: cxAIvDKv26b7n5OtArCgyUWgvkA Message-ID: Subject: Re: svn commit: r257945 - head/usr.sbin/pkg To: Bryan Drewery Content-Type: text/plain; charset=UTF-8 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , Gleb Smirnoff , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Nov 2013 19:20:09 -0000 On Mon, Nov 11, 2013 at 10:35 AM, Bryan Drewery wrote: > On Mon, Nov 11, 2013 at 07:44:10AM +0000, Gleb Smirnoff wrote: >> Author: glebius >> Date: Mon Nov 11 07:44:09 2013 >> New Revision: 257945 >> URL: http://svnweb.freebsd.org/changeset/base/257945 >> >> Log: >> Do not use just freed memory. >> >> Sponsored by: Nginx, Inc. > > Can you please also MFC this? > >> if (fingerprint->name) >> free(fingerprint->name); While here, can you remove the if conditional by the free? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams