From owner-svn-src-head@freebsd.org Wed Jan 13 01:17:42 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B0D5DA6E3F9 for ; Wed, 13 Jan 2016 01:17:42 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wm0-x22b.google.com (mail-wm0-x22b.google.com [IPv6:2a00:1450:400c:c09::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3FCFF1AC3 for ; Wed, 13 Jan 2016 01:17:42 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by mail-wm0-x22b.google.com with SMTP id b14so348080313wmb.1 for ; Tue, 12 Jan 2016 17:17:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=multiplay-co-uk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=nKE2xIPl8gQnsTSn/59o4EVRFbeTq/RmNf/377gimmI=; b=RY03++m+8lPw/W9aRdHd9D8PtYgOiK8uuKMamsYkdaWKbI0yDYNrwK10PeHQ6gmi51 bdjUBQDr38R2tQ6oHs7jiPKierjrXiHOvh8qaW/yqzYq3EhOTIf+beUbQu/w/t65QUh/ lVsgM6Y/KGNfzn3PN5XkNX7hiHMLjN+EKN3ALmNjTsUun/7Hr7iDIpWSaOHOTzuli5gw vcIpHYlha7Jf7wZbpBYwghPY5TQ7ZHL+yCLvJN5joTKMQLKjiv0VgSX+j4VCY/SS/CmU xRS5zHJZ86/V4nnTMxATENkicrGuOtPmADVQlae26dArhTKCFnHNDhQMb+W3285f2bj3 +YAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type; bh=nKE2xIPl8gQnsTSn/59o4EVRFbeTq/RmNf/377gimmI=; b=jwniQtBGKNx9Om4NzTatbjK3pbBdpmoipsNxTIiQOXLxDc1Pjuarcv8jbsAcrPVSdr O6Gi5qCAPMvkuPcz22giHWE21L/pU9X+Xa3JkzjeQ1LfRVSaegfVEsgH/fezeXS9W/eE F63lvpqtuhxv0FNu+dmXED1aSSH6hR9YQU3kd1mWRTxnUR2drgnSKTfJKytMvv93wFPp LrYLCmcCe7kia5rte5rZFH3fRyYrxIzgeau930Daguz4NpgS1/L9RVBSrt4oBaZPjldk C+Nb+Hv3+PEoQ2t8mw8QGAix4jW2UM4yFKlPSgF6AJNMYNeXLdhfdSuWmlhT5zp5vTw2 3gvA== X-Gm-Message-State: ALoCoQkmvvhTpZ7TfxW02Y0UXdtucGEle6vhmnDZ++Z0aULEpweb2jVQsIM88rIUDVYh2iQTg8VBKrjhjAMNExjCq7tgGVok1w== X-Received: by 10.28.145.204 with SMTP id t195mr23316142wmd.91.1452647860760; Tue, 12 Jan 2016 17:17:40 -0800 (PST) Received: from [10.10.1.58] (liv3d.labs.multiplay.co.uk. [82.69.141.171]) by smtp.gmail.com with ESMTPSA id e2sm13188372wma.1.2016.01.12.17.17.39 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 12 Jan 2016 17:17:39 -0800 (PST) Subject: Re: svn commit: r293724 - in head/sys/boot: arm64/libarm64 common efi/boot1 efi/fdt efi/include efi/include/arm64 efi/libefi efi/loader efi/loader/arch/amd64 efi/loader/arch/arm efi/loader/arch/arm64 i... To: Ian Lepore , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201601120217.u0C2HdBC089684@repo.freebsd.org> <1452645668.46848.34.camel@freebsd.org> <56959DA7.9050206@freebsd.org> <1452646442.46848.37.camel@freebsd.org> From: Steven Hartland Message-ID: <5695A5C4.9000409@multiplay.co.uk> Date: Wed, 13 Jan 2016 01:17:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1452646442.46848.37.camel@freebsd.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2016 01:17:42 -0000 On 13/01/2016 00:54, Ian Lepore wrote: > On Wed, 2016-01-13 at 00:43 +0000, Steven Hartland wrote: >> On 13/01/2016 00:41, Ian Lepore wrote: >>> On Tue, 2016-01-12 at 02:17 +0000, Steven Hartland wrote: >>>> Author: smh >>>> Date: Tue Jan 12 02:17:39 2016 >>>> New Revision: 293724 >>>> URL: https://svnweb.freebsd.org/changeset/base/293724 >>>> >>>> Log: >>>> Enable warnings in EFI boot code >>>> >>>> Set WARNS if not set for EFI boot code and fix the issues >>>> highlighted by >>>> setting it. >>>> >>> This appears to break arm builds when gcc is the compiler: >>> >>> cc1: warnings being treated as errors >>> In file included from >>> /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../include/e >>> fi.h:52, >>> from >>> /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/efi_fdt.c:35 >>> : >>> /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../include/e >>> fiapi.h:535: warning: function declaration isn't a prototype >>> In file included from >>> /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/efi_fdt.c:39 >>> : >>> /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../../common >>> /bootstrap.h:332: warning: redundant redeclaration of 'delay' >>> /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../include/e >>> filib.h:53: warning: previous declaration of 'delay' was here >>> /local/build/staging/freebsd/rm92/src/sys/boot/efi/fdt/../../common >>> /bootstrap.h:336: warning: redundant redeclaration of 'time' >>> /bsdstg/rm92/obj/arm.arm/local/build/staging/freebsd/rm92/src/tmp/u >>> sr/include/time.h:154: warning: previous declaration of 'time' was >>> here >>> >>> -- Ian >> Passes a full tinderbox so I assume your forcing gcc for some reason? > For several reasons. The fact that gcc isn't the default compiler > doesn't mean that it's okay for code to not compile with gcc; it's > still a supported compiler for arm. > > -- Ian Not disagreeing with that, was just curious that's all ;-) The warnings you list seem to be detail, typical gcc, specifically: sys/boot/efi/fdt/../include/efiapi.h:535: warning: function declaration isn't a prototype I'm guessing its being picky and wants EFI_RESERVED_SERVICE to have void in there due to no params. Does the following help: Index: sys/boot/efi/fdt/Makefile =================================================================== --- sys/boot/efi/fdt/Makefile (revision 293796) +++ sys/boot/efi/fdt/Makefile (working copy) @@ -7,6 +7,8 @@ LIB= efi_fdt INTERNALLIB= WARNS?= 6 +CWARNFLAGS.gcc+= -Wno-strict-prototypes +CWARNFLAGS.gcc+= -Wno-redundant-decls SRCS= efi_fdt.c @@ -34,4 +36,6 @@ CLEANFILES+= machine .include +CFLAGS+= ${CWARNFLAGS.${COMPILER_TYPE}} + beforedepend ${OBJS}: machine Could you detail detail how you're switching to gcc so I an run a full pass on that too? Regards Steve